Bugzilla – Attachment 149504 Details for
Bug 33445
Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Revert "Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail)"
Revert-Bug-29173-Fixed-pre-filling-of-the-search-f.patch (text/plain), 3.56 KB, created by
Phil Ringnalda
on 2023-04-11 21:18:14 UTC
(
hide
)
Description:
Revert "Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail)"
Filename:
MIME Type:
Creator:
Phil Ringnalda
Created:
2023-04-11 21:18:14 UTC
Size:
3.56 KB
patch
obsolete
>From cec277a721d93a6c1bb48b055d6bde2e38db78b4 Mon Sep 17 00:00:00 2001 >From: Phil Ringnalda <phil@chetcolibrary.org> >Date: Tue, 11 Apr 2023 14:11:26 -0700 >Subject: [PATCH] Revert "Bug 29173: Fixed pre-filling of the search form from > the "Replace record with ZR39.50/SRU" (Authority page detail)" > >This reverts commit 26c26164ba78029cb99fa99662f9e0a8ce9557df. > >Test plan: > >1. Without the patch, edit a personal name authority record, replacing >the value in 100 subfield a (200 subfield a for UNIMARC) with your own >name. >2. Click "Replace record via Z39.50/SRU search" and note that the >prefilled search field contains the original value, not your name. >3. Replace the Author (personal) field with your name again, choose >a search target, and click Search. >4. Note that the results of the search are for the original value, not >for your name. >5. Apply patch, repeat, noting that the search form is prefilled with >your change made in the editor, and any changes you make in the search >form are reflected in what the search results return. > >https://bugs.koha-community.org/show_bug.cgi?id=33445 >--- > cataloguing/z3950_auth_search.pl | 42 ++++---------------------------- > 1 file changed, 5 insertions(+), 37 deletions(-) > >diff --git a/cataloguing/z3950_auth_search.pl b/cataloguing/z3950_auth_search.pl >index 5b413201fa..da93dac37f 100755 >--- a/cataloguing/z3950_auth_search.pl >+++ b/cataloguing/z3950_auth_search.pl >@@ -24,51 +24,19 @@ use C4::Auth qw( get_template_and_user ); > use C4::Output qw( output_html_with_http_headers ); > use C4::Context; > use C4::Breeding qw( Z3950Search Z3950SearchAuth ); >-use MARC::Record; >-use Koha::Authorities; >-use Koha::Authority::Types; >-use C4::AuthoritiesMarc qw( GetAuthority ); > > my $input = CGI->new; > my $dbh = C4::Context->dbh; > my $error = $input->param('error'); > my $authid = $input->param('authid') || 0; >- >-my $record = GetAuthority($authid); >-my $marc_flavour = C4::Context->preference('marcflavour'); >-my $authfields_mapping = { >- 'authorpersonal' => $marc_flavour eq 'MARC21' ? '100' : '200', >- 'authorcorp' => $marc_flavour eq 'MARC21' ? '110' : '210', >- 'authormeetingcon' => $marc_flavour eq 'MARC21' ? '111' : '210', >- 'uniformtitle' => $marc_flavour eq 'MARC21' ? '130' : '230', >- 'subject' => $marc_flavour eq 'MARC21' ? '150' : '250', >-}; >- > my $nameany = $input->param('nameany'); > my $authorany = $input->param('authorany'); >-my $authorcorp = >- $record >- ? $record->subfield( $authfields_mapping->{'authorcorp'}, 'a' ) >- : $input->param('authorcorp'); >-my $authorpersonal = >- $record >- ? $record->subfield( $authfields_mapping->{'authorpersonal'}, 'a' ) >- : $input->param('authorpersonal'); >-my $authormeetingcon = >- $record >- ? $record->subfield( $authfields_mapping->{'authormeetingcon'}, 'a' ) >- : $input->param('authormeetingcon'); >- >+my $authorcorp = $input->param('authorcorp'); >+my $authorpersonal = $input->param('authorpersonal'); >+my $authormeetingcon = $input->param('authormeetingcon'); > my $title = $input->param('title'); >-my $uniformtitle = >- $record >- ? $record->subfield( $authfields_mapping->{'uniformtitle'}, 'a' ) >- : $input->param('uniformtitle'); >-my $subject = >- $record >- ? $record->subfield( $authfields_mapping->{'subject'}, 'a' ) >- : $input->param('subject'); >- >+my $uniformtitle = $input->param('uniformtitle'); >+my $subject = $input->param('subject'); > my $subjectsubdiv = $input->param('subjectsubdiv'); > my $srchany = $input->param('srchany'); > my $op = $input->param('op')||''; >-- >2.40.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33445
:
149504
|
149624
|
150367
|
150368
|
150419
|
150466
|
150467
|
150468
|
150469
|
150470
|
150471
|
150472
|
150473
|
150474
|
150475
|
151125
|
151126
|
151127