Bugzilla – Attachment 149580 Details for
Bug 33512
Labels/buttons are confusing on serials-edit page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33512: Change text and add button classes on serial-edit page
Bug-33512-Change-text-and-add-button-classes-on-se.patch (text/plain), 3.94 KB, created by
Lucas Gass (lukeg)
on 2023-04-12 22:29:30 UTC
(
hide
)
Description:
Bug 33512: Change text and add button classes on serial-edit page
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2023-04-12 22:29:30 UTC
Size:
3.94 KB
patch
obsolete
>From 35be2c1774a53e150772cf6042634f1a5a1bef8b Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 12 Apr 2023 22:28:06 +0000 >Subject: [PATCH] Bug 33512: Change text and add button classes on serial-edit > page > >To test: >1. Create a subscription >2. Make sure that you choose "Create an item record" when receiving the serial and associate it with a record. >3. Fill out the numbering pattern stuff and save the subscription. >4. Receive and change the status to arrived. Doing so will make the item subfields appear for editing. >5. Add some stuff, like a barcode, and Save. >6. Now, if you have made a mistake, you may want to edit the serial/item. Check the edit box and click 'Edit serials ' >7. For your issue that has already arrived click 'Click to add item'. The item record from before appears. >8. Apply patch. >9. Try 6 & 7 again. The existing items should now read 'Click to edit item' >--- > .../intranet-tmpl/prog/en/modules/serials/serials-edit.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >index fdea3ee1be..ccf79d19be 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >@@ -233,8 +233,8 @@ $(document).ready(function() { > [% IF ( serialslis.serialsadditems ) %] > <tr> > <td colspan="6"> >- <a id="label[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]" style="color: grey; font-size: 80%; cursor: pointer;" onclick="unHideItems('items[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]','label[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]', '[% serialslis.serialid | html %]');setStatus([% serialslis.serialid | html %]);"> >- Click to add item</a> >+ <a id="label[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]" class="btn btn-default btn-sm" onclick="unHideItems('items[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]','label[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]', '[% serialslis.serialid | html %]');setStatus([% serialslis.serialid | html %]);"> >+ Click to edit item</a> > <fieldset class="rows" style="display:none;" id="items[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]"> > <legend><a style="cursor: pointer;" onclick="HideItems('items[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]','label[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]')"> > Item</a> >@@ -386,7 +386,7 @@ $(document).ready(function() { > [% IF ( newserialloo.serialsadditems ) %] > <tr> > <td colspan="6"> >- <a id="label[% newserialloo.subscriptionid | html %][% newserialloo.serialid | html %]" style="color: grey; font-size: 80%; cursor: pointer;" onclick="unHideItems('items[% newserialloo.subscriptionid | html %][% newserialloo.serialid | html %]','label[% newserialloo.subscriptionid | html %][% newserialloo.serialid | html %]', '[% newserialloo.serialid | html %]')"> >+ <a id="label[% newserialloo.subscriptionid | html %][% newserialloo.serialid | html %]" class="btn btn-default btn-sm" onclick="unHideItems('items[% newserialloo.subscriptionid | html %][% newserialloo.serialid | html %]','label[% newserialloo.subscriptionid | html %][% newserialloo.serialid | html %]', '[% newserialloo.serialid | html %]')"> > Click to add item</a> > <fieldset class="rows" style="display:none;" id="items[% newserialloo.subscriptionid | html %][% newserialloo.serialid | html %]"> > <legend><a style="cursor: pointer;" onclick="HideItems('items[% newserialloo.subscriptionid | html %][% newserialloo.serialid | html %]','label[% newserialloo.subscriptionid | html %][% newserialloo.serialid | html %]')"> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33512
:
149580
|
149605
|
149719
|
149720
|
150179
|
150906
|
150907
|
150908