Bugzilla – Attachment 149585 Details for
Bug 33316
Improve display of ES indexer jobs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33316: Improve display of ES indexer jobs
Bug-33316-Improve-display-of-ES-indexer-jobs.patch (text/plain), 2.68 KB, created by
Jonathan Druart
on 2023-04-13 07:18:21 UTC
(
hide
)
Description:
Bug 33316: Improve display of ES indexer jobs
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2023-04-13 07:18:21 UTC
Size:
2.68 KB
patch
obsolete
>From 04470c695fae8751ceea3fba5bf31e56e7bc2859 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 22 Mar 2023 19:54:48 +0000 >Subject: [PATCH] Bug 33316: Improve display of ES indexer jobs > >We don't do a lot of processing to the data, but we can still >make the display a bit nicer, to show how many records were >done, and show the record ids. > >To test: >1 - Do some batch modifications on a system running ES >2 - Check background jobs to see ES jobs >3 - Note display >4 - Apply patch >5 - Confirm display is improved > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > .../background_jobs/update_elastic_index.inc | 26 +++++++++++++------ > 1 file changed, 18 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/update_elastic_index.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/update_elastic_index.inc >index d6f24e89a99..d50f7651c89 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/update_elastic_index.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/update_elastic_index.inc >@@ -1,18 +1,19 @@ > [% USE Koha %] > >+[% SET report = job.decoded_data %] > [% BLOCK report %] >- [% SET report = job.report %] >- [% IF report %] >- [% IF report.total_records == 1 %] >- [% IF report.total_success == 1 %] >- <div class="dialog message">The records have successfully been reindexed!</div> >- [% END %] >+ [% IF job.status == 'finished' %] >+ [% IF report %] >+ <div class="dialog message"> >+ [% report.record_ids.size | html %] records have successfully been reindexed. >+ </div> > [% ELSE %] > <div class="dialog message"> >- [% report.total_success | html %] / [% report.total_records | html %] records have successfully been reindexed. Some errors occurred. >- [% IF job.status == 'cancelled' %]<span>The job has been cancelled before it finished.</span>[% END %] >+ Job data could not be read, see the logs for details > </div> > [% END %] >+ [% ELSIF job.status == 'cancelled' %] >+ <span>The job has been cancelled before it finished.</span> > [% END %] > [% END %] > >@@ -32,7 +33,16 @@ > [% END %] > </div> > [% END %] >+ [% IF report %] >+ <h2> Record ids:</h2> >+ <ul> >+ [% FOREACH record_id IN report.record_ids %] >+ <li>[% record_id | html %]</li> >+ [% END %] >+ </ul> >+ [% END %] > [% END %] > >+ > [% BLOCK js %] > [% END %] >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33316
:
148570
|
148576
|
149394
|
149395
|
149396
|
149397
| 149585 |
149586