Attachment 149608 Details for Bug 33103 – Bug 33103: Fix accessibility issues

[patch] Bug 33103: Fix accessibility issues

Bug-33103-Fix-accessibility-issues.patch (text/plain), 1.76 KB, created by Jonathan Druart on 2023-04-13 15:06:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2023-04-13 15:06:24 UTC

Size: 1.76 KB

patch

obsolete

>From c865e58cd5d616fb16fc5f4643a3afdcc2c9bf76 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 11 Apr 2023 09:53:15 +0200
>Subject: [PATCH] Bug 33103: Fix accessibility issues
>
>* Add spaces
>* Add 'Add' and 'Remove' in addition of the icons
>* Do not submit the form when enter is hit
>* Fix translatability
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt
>index 2ccee3e9015..3e3e5ab8906 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt
>@@ -492,11 +492,11 @@
>                 let input = $('<input type="hidden" name="alias" />');
>                 input.val(a.alias);
>                 n.append(input);
>-                n.append(`<a onclick="remove_alias(${i});"><i class="fa fa-trash" aria-hidden="true"></i></a>`);
>+                n.append(` <a style="cursor: pointer;" onclick="remove_alias(${i});"><i class="fa fa-trash" aria-hidden="true"></i> ` + _("Remove") + '</a>');
>                 nodes.append(n);
>             });
>-            nodes.append("<input id='new_alias' type='text' />");
>-            nodes.append(`<a onclick="add_alias();"><i class="fa fa-plus" aria-hidden="true"></i></a>`);
>+            nodes.append("<input id='new_alias' type='text' class='noEnterSubmit' />");
>+            nodes.append(' <a style="cursor: pointer;" onclick="add_alias();"><i class="fa fa-plus" aria-hidden="true"></i> ' + _("Add") + '</a>');
>             $("#aliases").html(nodes.html());
>         }
> 
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 33103: 147621 | 147622 | 147623 | 147624 | 147625 | 147626 | 147627 | 147628 | 147629 | 147630 | 147645 | 147646 | 147647 | 147648 | 147649 | 147650 | 147651 | 147652 | 147653 | 147654 | 147827 | 148448 | 148449 | 148450 | 148451 | 148452 | 148453 | 148454 | 148455 | 148456 | 148457 | 148458 | 149414 | 149419 | 149479 | 149480 | 149481 | 149482 | 149483 | 149484 | 149485 | 149486 | 149487 | 149488 | 149489 | 149490 | 149491 | 149606 | 149607 | 149608 | 149609 | 149629 | 149630 | 149788