Bugzilla – Attachment 149616 Details for
Bug 33509
Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternate holdings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33509: Don't show Other holdings when there are no alternate holdings
Bug-33509-Dont-show-Other-holdings-when-there-are-.patch (text/plain), 2.06 KB, created by
David Nind
on 2023-04-13 17:26:53 UTC
(
hide
)
Description:
Bug 33509: Don't show Other holdings when there are no alternate holdings
Filename:
MIME Type:
Creator:
David Nind
Created:
2023-04-13 17:26:53 UTC
Size:
2.06 KB
patch
obsolete
>From 761be60e3e3acf0b77e616fe960f6d50f96133a8 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Wed, 12 Apr 2023 19:58:03 +0000 >Subject: [PATCH] Bug 33509: Don't show Other holdings when there are no > alternate holdings > >With bug 33509 alternate holdings defined in AlternateHoldingsField >are shown in the staff interface result list. This works greatly >when there are items or when there is are alternate holdings (the >configured field/subfields exist in the record), but not when there >are no items and no alternate holdings. > >To test: >* Add 100a to AlternateHoldingsField >* Make a search with some records without items > Sample data: perl >* Make sure the alternate holdings show when there are no items > and 100a exists >* Change to 100z >* Verify the result list now shows "Other holdings:" with nothing below >* Apply patch >* Repeat > * Alternate holdings should still show nicely > * Without alternate holdings 'no items' is displayed > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >index 862643e694..b6e4380640 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >@@ -676,7 +676,7 @@ > > [% ELSE # /IF ( SEARCH_RESULT.items_count ) %] > >- [% IF ( SEARCH_RESULT.ALTERNATEHOLDINGS ) %] >+ [% IF ( SEARCH_RESULT.ALTERNATEHOLDINGS.size ) %] > <strong id="altholdings_heading">Other holdings:</strong> > <ul> > [% FOREACH ALTERNATEHOLDING IN SEARCH_RESULT.ALTERNATEHOLDINGS %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33509
:
149575
|
149616
|
149639