Bugzilla – Attachment 149658 Details for
Bug 32450
Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32450: (QA follow-up) Fix QA test errors
Bug-32450-QA-follow-up-Fix-QA-test-errors.patch (text/plain), 1.95 KB, created by
Marcel de Rooy
on 2023-04-14 09:52:35 UTC
(
hide
)
Description:
Bug 32450: (QA follow-up) Fix QA test errors
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-04-14 09:52:35 UTC
Size:
1.95 KB
patch
obsolete
>From 77fa7eae0fd52ff78e2df051ab8b3b8a3dab634e Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >Date: Wed, 1 Mar 2023 14:55:38 +0000 >Subject: [PATCH] Bug 32450: (QA follow-up) Fix QA test errors >Content-Type: text/plain; charset=utf-8 > >Exec flag added to atomic update file, trailing whitespaces removed >Unit tests patched to remove duplicate variable names > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > .../mysql/atomicupdate/bug_32450-add_debit_type_flag.pl | 0 > t/db_dependent/Accounts.t | 8 ++++---- > 2 files changed, 4 insertions(+), 4 deletions(-) > mode change 100644 => 100755 installer/data/mysql/atomicupdate/bug_32450-add_debit_type_flag.pl > >diff --git a/installer/data/mysql/atomicupdate/bug_32450-add_debit_type_flag.pl b/installer/data/mysql/atomicupdate/bug_32450-add_debit_type_flag.pl >old mode 100644 >new mode 100755 >diff --git a/t/db_dependent/Accounts.t b/t/db_dependent/Accounts.t >index 7b8fbcf3bd..df53e0704b 100755 >--- a/t/db_dependent/Accounts.t >+++ b/t/db_dependent/Accounts.t >@@ -835,16 +835,16 @@ subtest "Koha::Account::non_issues_charges tests" => sub { > } > )->store; > >- my ( $total, $non_issues_charges ) = ( $account->balance, $account->non_issues_charges ); >- my $other_charges = $total - $non_issues_charges; >+ my ( $new_total, $new_non_issues_charges ) = ( $account->balance, $account->non_issues_charges ); >+ my $new_other_charges = $new_total - $new_non_issues_charges; > is( > $account->balance, > $res + $rent + $manual + $print, > 'Total charges should be Res + Rent + Manual + Print' > ); >- is( $non_issues_charges, 15, >+ is( $new_non_issues_charges, 15, > 'All types except Print should count towards the non issue charge' ); >- is( $other_charges, 4, 'There should be non-included charges for Print' ); >+ is( $new_other_charges, 4, 'There should be non-included charges for Print' ); > > }; > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32450
:
145080
|
145081
|
145127
|
145128
|
145171
|
145172
|
145189
|
145190
|
145191
|
145194
|
145198
|
147563
|
149653
|
149654
|
149655
|
149656
|
149657
|
149658
|
149659
|
149660
|
149858
|
149859
|
149872
|
149873
|
149874
|
149875
|
149876
|
149877
|
149878
|
149879
|
149880
|
149881
|
149882