Bugzilla – Attachment 149659 Details for
Bug 32450
Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32450: (QA follow-up) Polishing atomic update
Bug-32450-QA-follow-up-Polishing-atomic-update.patch (text/plain), 2.44 KB, created by
Marcel de Rooy
on 2023-04-14 09:52:38 UTC
(
hide
)
Description:
Bug 32450: (QA follow-up) Polishing atomic update
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-04-14 09:52:38 UTC
Size:
2.44 KB
patch
obsolete
>From 9502cf75415dc7977e2f4b4ae131e3c394b76399 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 14 Apr 2023 09:32:35 +0000 >Subject: [PATCH] Bug 32450: (QA follow-up) Polishing atomic update >Content-Type: text/plain; charset=utf-8 > >Database comment. >Variable names. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > .../atomicupdate/bug_32450-add_debit_type_flag.pl | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_32450-add_debit_type_flag.pl b/installer/data/mysql/atomicupdate/bug_32450-add_debit_type_flag.pl >index 404747061e..bd77117efb 100755 >--- a/installer/data/mysql/atomicupdate/bug_32450-add_debit_type_flag.pl >+++ b/installer/data/mysql/atomicupdate/bug_32450-add_debit_type_flag.pl >@@ -9,7 +9,9 @@ return { > > if( !column_exists( 'account_debit_types', 'restricts_checkouts' ) ) { > $dbh->do(q{ >- ALTER TABLE account_debit_types ADD COLUMN `restricts_checkouts` tinyint(1) NOT NULL DEFAULT 1 AFTER `archived` >+ ALTER TABLE account_debit_types ADD COLUMN `restricts_checkouts` tinyint(1) NOT NULL DEFAULT 1 >+ COMMENT 'boolean flag to denote if the noissuescharge syspref for this debit type is active' >+ AFTER `archived`; > }); > > say $out "Added column 'account_debit_types.restricts_checkouts'"; >@@ -20,7 +22,7 @@ return { > > # Hardcoded values from sub non_issues_charges > my @holds = ('RESERVE'); >- my @renewals = ('RENT', 'RENT_DAILY', 'RENT_RENEW', 'RENT_DAILY_RENEW'); >+ my @rentals = ('RENT', 'RENT_DAILY', 'RENT_RENEW', 'RENT_DAILY_RENEW'); > my @manual; > my $sth = $dbh->prepare("SELECT code FROM account_debit_types WHERE is_system = 0"); > $sth->execute; >@@ -51,7 +53,7 @@ return { > my @debit_types_to_update; > > if($_ eq 'ManInvInNoissuesCharge') { push @debit_types_to_update, @manual}; >- if($_ eq 'RentalsInNoissuesCharge') { push @debit_types_to_update, @renewals}; >+ if($_ eq 'RentalsInNoissuesCharge') { push @debit_types_to_update, @rentals}; > if($_ eq 'HoldsInNoissuesCharge') { push @debit_types_to_update, @holds}; > > my $string = join(",", map { $dbh->quote($_) } @debit_types_to_update); >@@ -74,4 +76,4 @@ return { > > } > }, >-}; >\ No newline at end of file >+}; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32450
:
145080
|
145081
|
145127
|
145128
|
145171
|
145172
|
145189
|
145190
|
145191
|
145194
|
145198
|
147563
|
149653
|
149654
|
149655
|
149656
|
149657
|
149658
|
149659
|
149660
|
149858
|
149859
|
149872
|
149873
|
149874
|
149875
|
149876
|
149877
|
149878
|
149879
|
149880
|
149881
|
149882