Bugzilla – Attachment 149709 Details for
Bug 32932
Re-structure Vue router-links to use "name" instead of urls
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32932: Update router to use object references - agreements
Bug-32932-Update-router-to-use-object-references--.patch (text/plain), 55.03 KB, created by
Agustín Moyano
on 2023-04-14 20:34:59 UTC
(
hide
)
Description:
Bug 32932: Update router to use object references - agreements
Filename:
MIME Type:
Creator:
Agustín Moyano
Created:
2023-04-14 20:34:59 UTC
Size:
55.03 KB
patch
obsolete
>From a3ff382d76940a237c34683e7ac0a801fad13aec Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >Date: Tue, 21 Mar 2023 16:14:45 -0300 >Subject: [PATCH] Bug 32932: Update router to use object references - > agreements > >This patch updates the Vue files for ERM to use router object links rather than urls - this will make it much simpler to maintain the router if urls need to be updated. This first patch only updates the files in the agreements section of ERM as a first step to introduce the topic for discussion. > >Test plan: >1) Apply patch >2) Navigate to the Agreements section of ERM and click on different navigation links/buttons >3) The links/buttons should all work as normal >4) Review the code to see that the component files now refer back to the router using objects rather than url strings > >Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> >--- > .../vue/components/ERM/AgreementsFormAdd.vue | 6 +-- > .../js/vue/components/ERM/AgreementsList.vue | 24 +++++----- > .../js/vue/components/ERM/AgreementsShow.vue | 45 ++++++++++++++++--- > .../vue/components/ERM/AgreementsToolbar.vue | 4 +- > .../ERM/EHoldingsEBSCOPackageAgreements.vue | 7 ++- > .../ERM/EHoldingsEBSCOPackageTitlesList.vue | 10 ++--- > .../ERM/EHoldingsEBSCOPackagesList.vue | 26 +++++------ > .../ERM/EHoldingsEBSCOPackagesShow.vue | 2 +- > .../ERM/EHoldingsEBSCOResourcesShow.vue | 10 ++++- > .../ERM/EHoldingsEBSCOTitlePackagesList.vue | 16 ++++--- > .../ERM/EHoldingsEBSCOTitlesList.vue | 25 ++++++----- > .../ERM/EHoldingsEBSCOTitlesShow.vue | 2 +- > .../ERM/EHoldingsLocalPackageTitlesList.vue | 10 ++--- > .../ERM/EHoldingsLocalPackagesFormAdd.vue | 14 +++--- > .../ERM/EHoldingsLocalPackagesList.vue | 20 ++++----- > .../ERM/EHoldingsLocalPackagesShow.vue | 22 ++++++--- > .../ERM/EHoldingsLocalPackagesToolbar.vue | 2 +- > .../ERM/EHoldingsLocalResourcesShow.vue | 10 ++++- > .../ERM/EHoldingsLocalTitlePackagesList.vue | 16 ++++--- > .../ERM/EHoldingsLocalTitlesFormAdd.vue | 14 +++--- > .../ERM/EHoldingsLocalTitlesList.vue | 19 ++++---- > .../ERM/EHoldingsLocalTitlesShow.vue | 13 +++--- > .../ERM/EHoldingsLocalTitlesToolbar.vue | 4 +- > .../js/vue/components/ERM/LicensesFormAdd.vue | 6 +-- > .../js/vue/components/ERM/LicensesList.vue | 15 +++---- > .../js/vue/components/ERM/LicensesShow.vue | 9 ++-- > .../js/vue/components/ERM/LicensesToolbar.vue | 2 +- > .../prog/js/vue/components/ERM/Main.vue | 4 +- > .../intranet-tmpl/prog/js/vue/routes/erm.js | 24 ++++++++++ > 29 files changed, 238 insertions(+), 143 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue >index bafe8ee118..118591229a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue >@@ -167,7 +167,7 @@ > <fieldset class="action"> > <ButtonSubmit /> > <router-link >- to="/cgi-bin/koha/erm/agreements" >+ :to="{ name: 'AgreementsList' }" > role="button" > class="cancel" > >{{ $__("Cancel") }}</router-link >@@ -376,7 +376,7 @@ export default { > client.agreements.update(agreement, agreement_id).then( > success => { > setMessage(this.$__("Agreement updated")) >- this.$router.push("/cgi-bin/koha/erm/agreements") >+ this.$router.push({ name: "AgreementsList" }) > }, > error => {} > ) >@@ -384,7 +384,7 @@ export default { > client.agreements.create(agreement).then( > success => { > setMessage(this.$__("Agreement created")) >- this.$router.push("/cgi-bin/koha/erm/agreements") >+ this.$router.push({ name: "AgreementsList" }) > }, > error => {} > ) >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >index 072ce02931..907f5793e6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >@@ -160,16 +160,18 @@ export default { > error => {} > ) > }, >- doShow: function (agreement, dt, event) { >+ doShow: function ({ agreement_id }, dt, event) { > event.preventDefault() >- this.$router.push( >- "/cgi-bin/koha/erm/agreements/" + agreement.agreement_id >- ) >+ this.$router.push({ >+ name: "AgreementsShow", >+ params: { agreement_id }, >+ }) > }, >- doEdit: function (agreement, dt, event) { >- this.$router.push( >- "/cgi-bin/koha/erm/agreements/edit/" + agreement.agreement_id >- ) >+ doEdit: function ({ agreement_id }, dt, event) { >+ this.$router.push({ >+ name: "AgreementsFormAddEdit", >+ params: { agreement_id }, >+ }) > }, > doDelete: function (agreement, dt, event) { > this.setConfirmationDialog( >@@ -211,10 +213,8 @@ export default { > }, > filter_table: async function () { > if (this.before_route_entered) { >- let new_route = build_url( >- "/cgi-bin/koha/erm/agreements", >- this.filters >- ) >+ let { href } = this.$router.resolve({ name: "AgreementsList" }) >+ let new_route = build_url(href, this.filters) > this.$router.push(new_route) > } > if (this.filters.by_expired) { >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue >index 4bc8d8be17..00bb7ec3a8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue >@@ -5,7 +5,10 @@ > {{ $__("Agreement #%s").format(agreement.agreement_id) }} > <span class="action_links"> > <router-link >- :to="`/cgi-bin/koha/erm/agreements/edit/${agreement.agreement_id}`" >+ :to="{ >+ name: 'AgreementsFormAddEdit', >+ params: { agreement_id: agreement.agreement_id }, >+ }" > :title="$__('Edit')" > ><i class="fa fa-pencil"></i > ></router-link> >@@ -159,7 +162,13 @@ > > > <td> > <router-link >- :to="`/cgi-bin/koha/erm/licenses/${agreement_license.license_id}`" >+ :to="{ >+ name: 'LicensesShow', >+ params: { >+ license_id: >+ agreement_license.license_id, >+ }, >+ }" > > > {{ agreement_license.license.name }} > </router-link> >@@ -196,7 +205,15 @@ > > > <span > ><router-link >- :to="`/cgi-bin/koha/erm/agreements/${relationship.related_agreement.agreement_id}`" >+ :to="{ >+ name: 'AgreementsShow', >+ params: { >+ agreement_id: >+ relationship >+ .related_agreement >+ .agreement_id, >+ }, >+ }" > >{{ > relationship.related_agreement.name > }}</router-link >@@ -228,7 +245,14 @@ > " > > > <router-link >- :to="`/cgi-bin/koha/erm/eholdings/ebsco/packages/${agreement_package.package.external_id}`" >+ :to="{ >+ name: 'EHoldingsEBSCOPackagesShow', >+ params: { >+ package_id: >+ agreement_package.package >+ .external_id, >+ }, >+ }" > >{{ > agreement_package.package.name > }}</router-link >@@ -237,7 +261,14 @@ > > > <span v-else > ><router-link >- :to="`/cgi-bin/koha/erm/eholdings/local/packages/${agreement_package.package.package_id}`" >+ :to="{ >+ name: 'EHoldingsLocalPackagesShow', >+ params: { >+ package_id: >+ agreement_package.package >+ .package_id, >+ }, >+ }" > >{{ > agreement_package.package.name > }}</router-link >@@ -288,7 +319,7 @@ > </fieldset> > <fieldset class="action"> > <router-link >- to="/cgi-bin/koha/erm/agreements" >+ :to="{ name: 'AgreementsList' }" > role="button" > class="cancel" > >{{ $__("Close") }}</router-link >@@ -379,7 +410,7 @@ export default { > ), > true > ) >- this.$router.push("/cgi-bin/koha/erm/agreements") >+ this.$router.push({ name: "AgreementsList" }) > }, > error => {} > ) >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsToolbar.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsToolbar.vue >index 035c326683..b61ceec2fc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsToolbar.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsToolbar.vue >@@ -1,8 +1,6 @@ > <template> > <div id="toolbar" class="btn-toolbar"> >- <router-link >- to="/cgi-bin/koha/erm/agreements/add" >- class="btn btn-default" >+ <router-link :to="{ name: 'AgreementsFormAdd' }" class="btn btn-default" > ><font-awesome-icon icon="plus" /> > {{ $__("New agreement") }}</router-link > > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackageAgreements.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackageAgreements.vue >index 734db3e594..a98f4940d2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackageAgreements.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackageAgreements.vue >@@ -17,7 +17,12 @@ > v-bind:key="counter" > > > <router-link >- :to="`/cgi-bin/koha/erm/agreements/${package_agreement.agreement.agreement_id}`" >+ :to="{ >+ name: 'AgreementsShow', >+ params: { >+ agreement_id: package_agreement.agreement.agreement_id, >+ }, >+ }" > >{{ package_agreement.agreement.name }}</router-link > > > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackageTitlesList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackageTitlesList.vue >index 27441804e0..677cab82c6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackageTitlesList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackageTitlesList.vue >@@ -129,12 +129,12 @@ export default { > } > }, > methods: { >- doShow: function (resource, dt, event) { >+ doShow: function ({ resource_id }, dt, event) { > event.preventDefault() >- this.$router.push( >- "/cgi-bin/koha/erm/eholdings/ebsco/resources/" + >- resource.resource_id >- ) >+ this.$router.push({ >+ name: "EHoldingsEBSCOResourcesShow", >+ params: { resource_id }, >+ }) > }, > filter_table: function () { > this.$refs.table.redraw( >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackagesList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackagesList.vue >index d2573e988f..b6dc1b7c96 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackagesList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackagesList.vue >@@ -145,25 +145,25 @@ export default { > }, > computed: { > local_packages_url() { >- return build_url( >- "/cgi-bin/koha/erm/eholdings/local/packages", >- this.filters >- ) >+ let { href } = this.$router.resolve({ >+ name: "EHoldingsLocalPackagesList", >+ }) >+ return build_url(href, this.filters) > }, > }, > methods: { >- doShow: function (erm_package, dt, event) { >+ doShow: function ({ package_id }, dt, event) { > event.preventDefault() >- this.$router.push( >- "/cgi-bin/koha/erm/eholdings/ebsco/packages/" + >- erm_package.package_id >- ) >+ this.$router.push({ >+ name: "EHoldingsEBSCOPackagesShow", >+ params: { package_id }, >+ }) > }, > filter_table: async function () { >- let new_route = build_url( >- "/cgi-bin/koha/erm/eholdings/ebsco/packages", >- this.filters >- ) >+ let { href } = this.$router.resolve({ >+ name: "EHoldingsEBSCOPackagesShow", >+ }) >+ let new_route = build_url(href, this.filters) > this.$router.push(new_route) > this.show_table = true > this.local_count_packages = null >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackagesShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackagesShow.vue >index 4b44034672..b3071af0b3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackagesShow.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackagesShow.vue >@@ -100,7 +100,7 @@ > </fieldset> > <fieldset class="action"> > <router-link >- to="/cgi-bin/koha/erm/eholdings/ebsco/packages" >+ :to="{ name: 'EHoldingsEBSCOPackagesList' }" > role="button" > class="cancel" > >{{ $__("Close") }}</router-link >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOResourcesShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOResourcesShow.vue >index 68d5e23e31..36aeef7501 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOResourcesShow.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOResourcesShow.vue >@@ -37,7 +37,10 @@ > <label>{{ $__("Publication title") }}:</label> > <span > ><router-link >- :to="`/cgi-bin/koha/erm/eholdings/ebsco/titles/${resource.title_id}`" >+ :to="{ >+ name: 'EHoldingsEBSCOTitlesShow', >+ params: { title_id: resource.title_id }, >+ }" > >{{ > resource.title.publication_title > }}</router-link >@@ -77,7 +80,10 @@ > <label>{{ $__("Package") }}:</label> > <span > ><router-link >- :to="`/cgi-bin/koha/erm/eholdings/ebsco/packages/${resource.package_id}`" >+ :to="{ >+ name: 'EHoldingsEBSCOPackagesShow', >+ params: { package_id: resource.package_id }, >+ }" > >{{ resource.package.name }}</router-link > ></span > > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOTitlePackagesList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOTitlePackagesList.vue >index 7b599667e7..8d7ee1e8c2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOTitlePackagesList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOTitlePackagesList.vue >@@ -66,9 +66,10 @@ export default { > }, > methods: { > show_resource: function (resource_id) { >- this.$router.push( >- "/cgi-bin/koha/erm/eholdings/ebsco/resources/" + resource_id >- ) >+ this.$router.push({ >+ name: "EHoldingsEBSCOResourcesShow", >+ params: { resource_id }, >+ }) > }, > toggle_filters: function (e) { > this.display_filters = !this.display_filters >@@ -83,6 +84,7 @@ export default { > let resources = this.resources > let filters = this.filters > let table_id = this.table_id >+ let router = this.$router > > $.fn.dataTable.ext.search = $.fn.dataTable.ext.search.filter( > search => search.name != "apply_filter" >@@ -122,13 +124,15 @@ export default { > let tr = $(this).parent() > let row = api.row(tr).data() > if (!row) return // Happen if the table is empty >+ let { href } = router.resolve({ >+ name: "EHoldingsEBSCOResourcesShow", >+ params: { resource_id: row.resource_id }, >+ }) > let n = createVNode( > "a", > { > role: "button", >- href: >- "/cgi-bin/koha/erm/eholdings/ebsco/resources/" + >- row.resource_id, >+ href, > onClick: e => { > e.preventDefault() > show_resource(row.resource_id) >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOTitlesList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOTitlesList.vue >index c29c9a2783..7b446b4d8d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOTitlesList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOTitlesList.vue >@@ -149,26 +149,27 @@ export default { > }, > computed: { > local_titles_url() { >- return build_url( >- "/cgi-bin/koha/erm/eholdings/local/titles", >- this.filters >- ) >+ let { href } = this.$router.resolve({ >+ name: "EHoldingsLocalTitlesList", >+ }) >+ return build_url(href, this.filters) > }, > }, > methods: { >- doShow: function (title, dt, event) { >+ doShow: function ({ title_id }, dt, event) { > event.preventDefault() >- this.$router.push( >- "/cgi-bin/koha/erm/eholdings/ebsco/titles/" + title.title_id >- ) >+ this.$router.push({ >+ name: "EHoldingsEBSCOTitlesShow", >+ params: { title_id }, >+ }) > }, > filter_table: async function () { > if (this.filters.publication_title.length) { > this.cannot_search = false >- let new_route = build_url( >- "/cgi-bin/koha/erm/eholdings/ebsco/titles", >- this.filters >- ) >+ let { href } = this.$router.resolve({ >+ name: "EHoldingsEBSCOTitlesList", >+ }) >+ let new_route = build_url(href, this.filters) > this.$router.push(new_route) > this.show_table = true > this.local_title_count = null >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOTitlesShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOTitlesShow.vue >index 8ea3ef6fde..53b6d2b5e2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOTitlesShow.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOTitlesShow.vue >@@ -232,7 +232,7 @@ > </fieldset> > <fieldset class="action"> > <router-link >- to="/cgi-bin/koha/erm/eholdings/ebsco/titles" >+ :to="{ name: 'EHoldingsEBSCOTitlesList' }" > role="button" > class="cancel" > >{{ $__("Close") }}</router-link >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackageTitlesList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackageTitlesList.vue >index b94b44ca40..dc095cb674 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackageTitlesList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackageTitlesList.vue >@@ -42,12 +42,12 @@ export default { > } > }, > methods: { >- doShow: function (resource, dt, event) { >+ doShow: function ({ resource_id }, dt, event) { > event.preventDefault() >- this.$router.push( >- "/cgi-bin/koha/erm/eholdings/local/resources/" + >- resource.resource_id >- ) >+ this.$router.push({ >+ name: "EHoldingsLocalResourcesShow", >+ params: { resource_id }, >+ }) > }, > getTableColumns: function () { > let get_lib_from_av = this.get_lib_from_av >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesFormAdd.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesFormAdd.vue >index 268af004b2..8e58e09d10 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesFormAdd.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesFormAdd.vue >@@ -73,7 +73,7 @@ > <fieldset class="action"> > <input type="submit" value="Submit" /> > <router-link >- to="/cgi-bin/koha/erm/eholdings/local/packages" >+ :to="{ name: 'EHoldingsLocalPackagesList' }" > role="button" > class="cancel" > >{{ $__("Cancel") }}</router-link >@@ -184,9 +184,9 @@ export default { > client.localPackages.update(erm_package, package_id).then( > success => { > setMessage(this.$__("Package updated")) >- this.$router.push( >- "/cgi-bin/koha/erm/eholdings/local/packages" >- ) >+ this.$router.push({ >+ name: "EHoldingsLocalPackagesList", >+ }) > }, > error => {} > ) >@@ -194,9 +194,9 @@ export default { > client.localPackages.create(erm_package).then( > success => { > setMessage(this.$__("Package created")) >- this.$router.push( >- "/cgi-bin/koha/erm/eholdings/local/packages" >- ) >+ this.$router.push({ >+ name: "EHoldingsLocalPackagesList", >+ }) > }, > error => {} > ) >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesList.vue >index b78dab4de9..8e35e26792 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesList.vue >@@ -115,18 +115,18 @@ export default { > error => {} > ) > }, >- doShow: function (erm_package, dt, event) { >+ doShow: function ({ package_id }, dt, event) { > event.preventDefault() >- this.$router.push( >- "/cgi-bin/koha/erm/eholdings/local/packages/" + >- erm_package.package_id >- ) >+ this.$router.push({ >+ name: "EHoldingsLocalPackagesShow", >+ params: { package_id }, >+ }) > }, >- doEdit: function (erm_package, dt, event) { >- this.$router.push( >- "/cgi-bin/koha/erm/eholdings/local/packages/edit/" + >- erm_package.package_id >- ) >+ doEdit: function ({ package_id }, dt, event) { >+ this.$router.push({ >+ name: "EHoldingsLocalPackagesFormAddEdit", >+ params: { package_id }, >+ }) > }, > doDelete: function (erm_package, dt, event) { > this.setConfirmationDialog( >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesShow.vue >index 5cf5455f56..e2e2c9bbe6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesShow.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesShow.vue >@@ -5,7 +5,10 @@ > {{ $__("Package #%s").format(erm_package.package_id) }} > <span class="action_links"> > <router-link >- :to="`/cgi-bin/koha/erm/eholdings/local/packages/edit/${erm_package.package_id}`" >+ :to="{ >+ name: 'EHoldingsLocalPackagesFormAddEdit', >+ params: { package_id: erm_package.package_id }, >+ }" > :title="$__('Edit')" > ><i class="fa fa-pencil"></i > ></router-link> >@@ -69,7 +72,14 @@ > :key="package_agreement.agreement_id" > > > <router-link >- :to="`/cgi-bin/koha/erm/agreements/${package_agreement.agreement.agreement_id}`" >+ :to="{ >+ name: 'AgreementsShow', >+ params: { >+ agreement_id: >+ package_agreement.agreement >+ .agreement_id, >+ }, >+ }" > >{{ > package_agreement.agreement.name > }}</router-link >@@ -92,7 +102,7 @@ > </fieldset> > <fieldset class="action"> > <router-link >- to="/cgi-bin/koha/erm/eholdings/local/packages" >+ :to="{ name: 'EHoldingsLocalPackagesList' }" > role="button" > class="cancel" > >{{ $__("Close") }}</router-link >@@ -178,9 +188,9 @@ export default { > ), > true > ) >- this.$router.push( >- "/cgi-bin/koha/erm/eholdings/local/packages" >- ) >+ this.$router.push({ >+ name: "EHoldingsLocalPackagesList", >+ }) > }, > error => {} > ) >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesToolbar.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesToolbar.vue >index 6b31743d05..49610bd891 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesToolbar.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesToolbar.vue >@@ -1,7 +1,7 @@ > <template> > <div id="toolbar" class="btn-toolbar"> > <router-link >- to="/cgi-bin/koha/erm/eholdings/local/packages/add" >+ :to="{ name: 'EHoldingsLocalPackagesFormAdd' }" > class="btn btn-default" > ><font-awesome-icon icon="plus" /> > {{ $__("New package") }}</router-link >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalResourcesShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalResourcesShow.vue >index 3a043cfd2c..6798e36d87 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalResourcesShow.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalResourcesShow.vue >@@ -18,7 +18,10 @@ > <label>{{ $__("Publication title") }}:</label> > <span > ><router-link >- :to="`/cgi-bin/koha/erm/eholdings/local/titles/${resource.title_id}`" >+ :to="{ >+ name: 'EHoldingsLocalTitlesShow', >+ params: { title_id: resource.title_id }, >+ }" > >{{ > resource.title.publication_title > }}</router-link >@@ -58,7 +61,10 @@ > <label>{{ $__("Package") }}:</label> > <span > ><router-link >- :to="`/cgi-bin/koha/erm/eholdings/local/packages/${resource.package_id}`" >+ :to="{ >+ name: 'EHoldingsLocalPackagesShow', >+ params: { package_id: resource.package_id }, >+ }" > >{{ resource.package.name }}</router-link > ></span > > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlePackagesList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlePackagesList.vue >index 85646aa2a4..91ab7732a9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlePackagesList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlePackagesList.vue >@@ -22,12 +22,14 @@ export default { > }, > methods: { > show_resource: function (resource_id) { >- this.$router.push( >- "/cgi-bin/koha/erm/eholdings/local/resources/" + resource_id >- ) >+ this.$router.push({ >+ name: "EHoldingsLocalResourcesShow", >+ params: { resource_id }, >+ }) > }, > build_datatable: function () { > let show_resource = this.show_resource >+ let router = this.$router > let resources = this.resources > let table_id = this.table_id > >@@ -59,13 +61,15 @@ export default { > let tr = $(this).parent() > let row = api.row(tr).data() > if (!row) return // Happen if the table is empty >+ let { href } = router.resolve({ >+ name: "EHoldingsLocalResourcesShow", >+ params: { resource_id }, >+ }) > let n = createVNode( > "a", > { > role: "button", >- href: >- "/cgi-bin/koha/erm/eholdings/local/resources/" + >- row.resource_id, >+ href, > onClick: e => { > e.preventDefault() > show_resource(row.resource_id) >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesFormAdd.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesFormAdd.vue >index 2c30ab9e0e..19afc5e8f9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesFormAdd.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesFormAdd.vue >@@ -373,7 +373,7 @@ > <fieldset class="action"> > <input type="submit" value="Submit" /> > <router-link >- to="/cgi-bin/koha/erm/eholdings/local/titles" >+ :to="{ name: 'EHoldingsLocalTitlesList' }" > role="button" > class="cancel" > >{{ $__("Cancel") }}</router-link >@@ -502,9 +502,9 @@ export default { > client.localTitles.update(title, title_id).then( > success => { > setMessage(this.$__("Title updated")) >- this.$router.push( >- "/cgi-bin/koha/erm/eholdings/local/titles" >- ) >+ this.$router.push({ >+ name: "EHoldingsLocalTitlesList", >+ }) > }, > error => {} > ) >@@ -512,9 +512,9 @@ export default { > client.localTitles.create(title).then( > success => { > setMessage(this.$__("Title created")) >- this.$router.push( >- "/cgi-bin/koha/erm/eholdings/local/titles" >- ) >+ this.$router.push({ >+ name: "EHoldingsLocalTitlesList", >+ }) > }, > error => {} > ) >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesList.vue >index de9b39f957..a6a4a865f0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesList.vue >@@ -107,17 +107,18 @@ export default { > error => {} > ) > }, >- doShow: function (title, dt, event) { >+ doShow: function ({ title_id }, dt, event) { > event.preventDefault() >- this.$router.push( >- "/cgi-bin/koha/erm/eholdings/local/titles/" + title.title_id >- ) >+ this.$router.push({ >+ name: "EHoldingsLocalTitlesShow", >+ params: { title_id }, >+ }) > }, >- doEdit: function (title, dt, event) { >- this.$router.push( >- "/cgi-bin/koha/erm/eholdings/local/titles/edit/" + >- title.title_id >- ) >+ doEdit: function ({ title_id }, dt, event) { >+ this.$router.push({ >+ name: "EHoldingsLocalTitlesFormAddEdit", >+ params: { title_id }, >+ }) > }, > doDelete: function (title, dt, event) { > this.setConfirmationDialog( >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesShow.vue >index e6efc4a339..24fdddf81a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesShow.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesShow.vue >@@ -5,7 +5,10 @@ > {{ $__("Title #%s").format(title.title_id) }} > <span class="action_links"> > <router-link >- :to="`/cgi-bin/koha/erm/eholdings/local/titles/edit/${title.title_id}`" >+ :to="{ >+ name: 'EHoldingsLocalTitlesFormAddEdit', >+ params: { title_id: title.title_id }, >+ }" > :title="$__('Edit')" > ><i class="fa fa-pencil"></i > ></router-link> >@@ -246,7 +249,7 @@ > </fieldset> > <fieldset class="action"> > <router-link >- to="/cgi-bin/koha/erm/eholdings/local/titles" >+ :to="{ name: 'EHoldingsLocalTitlesList' }" > role="button" > class="cancel" > >{{ $__("Close") }}</router-link >@@ -346,9 +349,9 @@ export default { > ), > true > ) >- this.$router.push( >- "/cgi-bin/koha/erm/eholdings/local/titles" >- ) >+ this.$router.push({ >+ name: "EHoldingsLocalTitlesList", >+ }) > }, > error => {} > ) >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesToolbar.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesToolbar.vue >index 027af77447..f9495d95c1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesToolbar.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesToolbar.vue >@@ -1,14 +1,14 @@ > <template> > <div id="toolbar" class="btn-toolbar"> > <router-link >- to="/cgi-bin/koha/erm/eholdings/local/titles/add" >+ :to="{ name: 'EHoldingsLocalTitlesFormAdd' }" > class="btn btn-default" > ><font-awesome-icon icon="plus" /> > {{ $__("New title") }}</router-link > > > > <router-link >- to="/cgi-bin/koha/erm/eholdings/local/titles/import" >+ :to="{ name: 'EHoldingsLocalTitlesFormImport' }" > class="btn btn-default" > ><font-awesome-icon icon="plus" /> > {{ $__("Import from list") }}</router-link >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesFormAdd.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesFormAdd.vue >index 272253cadf..d93ee9c51c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesFormAdd.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesFormAdd.vue >@@ -135,7 +135,7 @@ > <fieldset class="action"> > <input type="submit" :value="$__('Submit')" /> > <router-link >- to="/cgi-bin/koha/erm/licenses" >+ :to="{ name: 'LicensesList' }" > role="button" > class="cancel" > >{{ $__("Cancel") }}</router-link >@@ -266,7 +266,7 @@ export default { > client.licenses.update(license, license_id).then( > success => { > setMessage(this.$__("License updated")) >- this.$router.push("/cgi-bin/koha/erm/licenses") >+ this.$router.push({ name: "LicensesList" }) > }, > error => {} > ) >@@ -274,7 +274,7 @@ export default { > client.licenses.create(license).then( > success => { > setMessage(this.$__("License created")) >- this.$router.push("/cgi-bin/koha/erm/licenses") >+ this.$router.push({ name: "LicensesList" }) > }, > error => {} > ) >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue >index 2db4d82e50..78acd16c48 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue >@@ -88,16 +88,15 @@ export default { > error => {} > ) > }, >- doShow: function (license, dt, event) { >+ doShow: function ({ license_id }, dt, event) { > event.preventDefault() >- this.$router.push( >- "/cgi-bin/koha/erm/licenses/" + license.license_id >- ) >+ this.$router.push({ name: "LicensesShow", params: { license_id } }) > }, >- doEdit: function (license, dt, event) { >- this.$router.push( >- "/cgi-bin/koha/erm/licenses/edit/" + license.license_id >- ) >+ doEdit: function ({ license_id }, dt, event) { >+ this.$router.push({ >+ name: "LicensesFormAddEdit", >+ params: { license_id }, >+ }) > }, > doDelete: function (license, dt, event) { > this.setConfirmationDialog( >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesShow.vue >index 64c1349cf2..19c853f4aa 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesShow.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesShow.vue >@@ -5,7 +5,10 @@ > {{ $__("License #%s").format(license.license_id) }} > <span class="action_links"> > <router-link >- :to="`/cgi-bin/koha/erm/licenses/edit/${license.license_id}`" >+ :to="{ >+ name: 'LicensesFormAddEdit', >+ params: { license_id: license.license_id }, >+ }" > :title="$__('Edit')" > ><i class="fa fa-pencil"></i > ></router-link> >@@ -131,7 +134,7 @@ > </fieldset> > <fieldset class="action"> > <router-link >- to="/cgi-bin/koha/erm/licenses" >+ :to="{ name: 'LicensesList' }" > role="button" > class="cancel" > >{{ $__("Close") }}</router-link >@@ -216,7 +219,7 @@ export default { > ), > true > ) >- this.$router.push("/cgi-bin/koha/erm/licenses") >+ this.$router.push({ name: "LicensesList" }) > }, > error => {} > ) >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesToolbar.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesToolbar.vue >index 510fbff57e..829ed5a47a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesToolbar.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesToolbar.vue >@@ -1,6 +1,6 @@ > <template> > <div id="toolbar" class="btn-toolbar"> >- <router-link to="/cgi-bin/koha/erm/licenses/add" class="btn btn-default" >+ <router-link :to="{ name: 'LicensesFormAdd' }" class="btn btn-default" > ><font-awesome-icon icon="plus" /> > {{ $__("New license") }}</router-link > > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue >index 9f4a1c99dd..71685ee443 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue >@@ -21,7 +21,7 @@ > <ul> > <li> > <router-link >- to="/cgi-bin/koha/erm/agreements" >+ :to="{ name: 'AgreementsList' }" > > > <i class="fa fa-check-circle-o"></i> > {{ $__("Agreements") }}</router-link >@@ -29,7 +29,7 @@ > </li> > <li> > <router-link >- to="/cgi-bin/koha/erm/licenses" >+ :to="{ name: 'LicensesList' }" > > > <i class="fa fa-gavel"></i> > {{ $__("Licenses") }}</router-link >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js b/koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js >index fb85986919..26f9f8f829 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js >@@ -121,6 +121,7 @@ export const routes = [ > }, > { > path: "/cgi-bin/koha/erm/erm.pl", >+ name: "Home", > component: Home, > meta: { > breadcrumb: () => [breadcrumbs.home, breadcrumbs.erm_home], >@@ -131,6 +132,7 @@ export const routes = [ > children: [ > { > path: "", >+ name: "AgreementsList", > component: AgreementsList, > meta: { > breadcrumb: () => breadcrumb_paths.agreements, >@@ -138,6 +140,7 @@ export const routes = [ > }, > { > path: ":agreement_id", >+ name: "AgreementsShow", > component: AgreementsShow, > meta: { > breadcrumb: () => >@@ -149,6 +152,7 @@ export const routes = [ > }, > { > path: "add", >+ name: "AgreementsFormAdd", > component: AgreementsFormAdd, > meta: { > breadcrumb: () => >@@ -160,6 +164,7 @@ export const routes = [ > }, > { > path: "edit/:agreement_id", >+ name: "AgreementsFormAddEdit", > component: AgreementsFormAdd, > meta: { > breadcrumb: () => >@@ -197,6 +202,7 @@ export const routes = [ > children: [ > { > path: "", >+ name: "EHoldingsLocalPackagesList", > component: EHoldingsLocalPackagesList, > meta: { > breadcrumb: () => >@@ -209,6 +215,7 @@ export const routes = [ > }, > { > path: ":package_id", >+ name: "EHoldingsLocalPackagesShow", > component: EHoldingsLocalPackagesShow, > meta: { > breadcrumb: () => >@@ -224,6 +231,7 @@ export const routes = [ > }, > { > path: "add", >+ name: "EHoldingsLocalPackagesFormAdd", > component: EHoldingsLocalPackagesFormAdd, > meta: { > breadcrumb: () => >@@ -239,6 +247,7 @@ export const routes = [ > }, > { > path: "edit/:package_id", >+ name: "EHoldingsLocalPackagesFormAddEdit", > component: EHoldingsLocalPackagesFormAdd, > meta: { > breadcrumb: () => >@@ -259,6 +268,7 @@ export const routes = [ > children: [ > { > path: "", >+ name: "EHoldingsLocalTitlesList", > component: EHoldingsLocalTitlesList, > meta: { > breadcrumb: () => >@@ -270,6 +280,7 @@ export const routes = [ > }, > { > path: ":title_id", >+ name: "EHoldingsLocalTitlesShow", > component: EHoldingsLocalTitlesShow, > meta: { > breadcrumb: () => >@@ -285,6 +296,7 @@ export const routes = [ > }, > { > path: "add", >+ name: "EHoldingsLocalTitlesFormAdd", > component: EHoldingsLocalTitlesFormAdd, > meta: { > breadcrumb: () => >@@ -300,6 +312,7 @@ export const routes = [ > }, > { > path: "edit/:title_id", >+ name: "EHoldingsLocalTitlesFormAddEdit", > component: EHoldingsLocalTitlesFormAdd, > meta: { > breadcrumb: () => >@@ -315,6 +328,7 @@ export const routes = [ > }, > { > path: "import", >+ name: "EHoldingsLocalTitlesFormImport", > component: EHoldingsLocalTitlesFormImport, > meta: { > breadcrumb: () => >@@ -332,6 +346,7 @@ export const routes = [ > }, > { > path: "resources/:resource_id", >+ name: "EHoldingsLocalResourcesShow", > component: EHoldingsLocalResourcesShow, > meta: { > breadcrumb: () => >@@ -360,6 +375,7 @@ export const routes = [ > children: [ > { > path: "", >+ name: "EHoldingsEBSCOPackagesList", > component: EHoldingsEBSCOPackagesList, > meta: { > breadcrumb: () => >@@ -372,6 +388,7 @@ export const routes = [ > }, > { > path: ":package_id", >+ name: "EHoldingsEBSCOPackagesShow", > component: EHoldingsEBSCOPackagesShow, > meta: { > breadcrumb: () => >@@ -392,6 +409,7 @@ export const routes = [ > children: [ > { > path: "", >+ name: "EHoldingsEBSCOTitlesList", > component: EHoldingsEBSCOTitlesList, > meta: { > breadcrumb: () => >@@ -403,6 +421,7 @@ export const routes = [ > }, > { > path: ":title_id", >+ name: "EHoldingsEBSCOTitlesShow", > component: EHoldingsEBSCOTitlesShow, > meta: { > breadcrumb: () => >@@ -420,6 +439,7 @@ export const routes = [ > }, > { > path: "resources/:resource_id", >+ name: "EHoldingsEBSCOResourcesShow", > component: EHoldingsEBSCOResourcesShow, > meta: { > breadcrumb: () => >@@ -441,6 +461,7 @@ export const routes = [ > children: [ > { > path: "", >+ name: "LicensesList", > component: LicensesList, > meta: { > breadcrumb: () => breadcrumb_paths.licenses, >@@ -448,6 +469,7 @@ export const routes = [ > }, > { > path: ":license_id", >+ name: "LicensesShow", > component: LicensesShow, > meta: { > breadcrumb: () => >@@ -459,6 +481,7 @@ export const routes = [ > }, > { > path: "add", >+ name: "LicensesFormAdd", > component: LicensesFormAdd, > meta: { > breadcrumb: () => >@@ -470,6 +493,7 @@ export const routes = [ > }, > { > path: "edit/:license_id", >+ name: "LicensesFormAddEdit", > component: LicensesFormAdd, > meta: { > breadcrumb: () => >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32932
:
146439
|
146442
|
146616
|
146617
|
146618
|
146624
|
146625
|
146965
|
146966
|
146967
|
146968
|
147119
|
147120
|
147121
|
147122
|
148115
|
148551
|
148552
|
148553
|
148554
|
148558
|
148559
|
148560
|
148561
|
149210
|
149707
|
149709
|
149934
|
149935
|
151529
|
152231