Attachment 149745 Details for Bug 18829 – Bug 18829: (QA follow-up) Replace forbidden indirect syntax

[patch] Bug 18829: (QA follow-up) Replace forbidden indirect syntax

Bug-18829-QA-follow-up-Replace-forbidden-indirect-.patch (text/plain), 1.05 KB, created by Tomás Cohen Arazi (tcohen) on 2023-04-17 11:26:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2023-04-17 11:26:39 UTC

Size: 1.05 KB

patch

obsolete

>From e7724c0bd7262433384e1b9a8894af8162784f76 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 17 Apr 2023 08:24:12 -0300
>Subject: [PATCH] Bug 18829: (QA follow-up) Replace forbidden indirect syntax
>
>This pattern is forbidden and was overlooked by QA.
>
>To test:
>1. Run:
>   $ ktd --shell
>  k$ prove t/00-testcritic.t
>=> FAIL: Tests fail with 'Subroutine "new" called using indirect
>syntax...'
>2. Apply this patch
>3. Repeat 1
>=> SUCCESS: Tests pass
>4. Sign off :-D
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> catalogue/showelastic.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/catalogue/showelastic.pl b/catalogue/showelastic.pl
>index 6bbf569b640..d9b2c53dbd4 100755
>--- a/catalogue/showelastic.pl
>+++ b/catalogue/showelastic.pl
>@@ -39,7 +39,7 @@ use C4::XSLT ;
> use Koha::SearchEngine::Elasticsearch;
> use LWP::Simple qw/get/;
> 
>-my $input= new CGI;
>+my $input= CGI->new;
> my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
>   {
>     template_name   => "catalogue/showelastic.tt",
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 18829: 64456 | 89001 | 89007 | 89248 | 89249 | 89250 | 90370 | 108103 | 108104 | 108191 | 108944 | 108945 | 148757 | 148758 | 148759 | 148760 | 149400 | 149401 | 149402 | 149403 | 149404 | 149745