Bugzilla – Attachment 149783 Details for
Bug 32092
Improve circulation rules cache utilization
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32092: Fix tests
Bug-32092-Fix-tests.patch (text/plain), 1.49 KB, created by
Emily Lamancusa (emlam)
on 2023-04-17 21:08:22 UTC
(
hide
)
Description:
Bug 32092: Fix tests
Filename:
MIME Type:
Creator:
Emily Lamancusa (emlam)
Created:
2023-04-17 21:08:22 UTC
Size:
1.49 KB
patch
obsolete
>From 55b3d99fb6af09f6d768f9d51e69f4d027e6404b Mon Sep 17 00:00:00 2001 >From: David Gustafsson <david.gustafsson@ub.gu.se> >Date: Wed, 22 Feb 2023 14:44:52 +0100 >Subject: [PATCH] Bug 32092: Fix tests > >Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >--- > t/db_dependent/Koha/CirculationRules.t | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/t/db_dependent/Koha/CirculationRules.t b/t/db_dependent/Koha/CirculationRules.t >index 18c8653523..86bd7e1dae 100755 >--- a/t/db_dependent/Koha/CirculationRules.t >+++ b/t/db_dependent/Koha/CirculationRules.t >@@ -580,9 +580,13 @@ subtest 'get_onshelfholds_policy() tests' => sub { > } > ); > >+ my $memory_cache = Koha::Cache::Memory::Lite->get_instance; >+ $memory_cache->flush(); >+ > is( $circ_rules->get_onshelfholds_policy({ item => $item }), 1, 'If rule_value is set on a matching rule, return it' ); > # Delete the rule (i.e. get_effective_rule returns undef) > $circ_rules->delete; >+ $memory_cache->flush(); > is( $circ_rules->get_onshelfholds_policy({ item => $item }), 0, 'If no matching rule, fallback to 0' ); > > $schema->storage->txn_rollback; >@@ -853,6 +857,7 @@ subtest 'get_lostreturn_policy() tests' => sub { > ) > ->next > ->delete; >+ $memory_cache->flush(); > is_deeply( Koha::CirculationRules->get_lostreturn_policy( $params ), > { lostreturn => 'refund', processingreturn => 'refund' },'No rule for branch, no default rule, fallback default (refund)'); > >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32092
:
143120
|
146956
|
147149
|
147150
|
147151
|
149782
|
149783
|
151195
|
151196
|
151197
|
151709
|
151710
|
151711
|
153168
|
153169
|
153170
|
157534
|
157535
|
157536
|
157537
|
157551