Bugzilla – Attachment 149800 Details for
Bug 32484
Enable framework plugins when UseACQFrameworkForBiblioRecords is set
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32484: (QA follow-up) Fixes to POD
Bug-32484-QA-follow-up-Fixes-to-POD.patch (text/plain), 1.41 KB, created by
Marcel de Rooy
on 2023-04-18 13:05:27 UTC
(
hide
)
Description:
Bug 32484: (QA follow-up) Fixes to POD
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-04-18 13:05:27 UTC
Size:
1.41 KB
patch
obsolete
>From 9ccd022bd67e02f3c57db39af96aebd72e86bf78 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 18 Apr 2023 12:32:46 +0000 >Subject: [PATCH] Bug 32484: (QA follow-up) Fixes to POD >Content-Type: text/plain; charset=utf-8 > >Resolve: > FAIL Koha/UI/Form/Builder/Biblio.pm > FAIL pod coverage > POD is missing for build_authorized_values_list > POD is missing for create_key > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > Koha/UI/Form/Builder/Biblio.pm | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > >diff --git a/Koha/UI/Form/Builder/Biblio.pm b/Koha/UI/Form/Builder/Biblio.pm >index eca798b06d..7465eeffff 100644 >--- a/Koha/UI/Form/Builder/Biblio.pm >+++ b/Koha/UI/Form/Builder/Biblio.pm >@@ -57,7 +57,7 @@ sub new { > > =head3 generate_subfield_form > >-Generate subfield's info for given tag, subfieldtag, etc. >+ Generate subfield's info for given tag, subfieldtag, etc. > > =cut > >@@ -280,6 +280,12 @@ sub generate_subfield_form { > return \%subfield_data; > } > >+=head3 build_authorized_values_list >+ >+ Return list of authorized values for given tag, subfield >+ >+=cut >+ > sub build_authorized_values_list { > my ($self, $params) = @_; > >@@ -365,6 +371,12 @@ sub build_authorized_values_list { > > } > >+=head3 create_key >+ >+ Create unique key for subfields >+ >+=cut >+ > sub create_key { > return int(rand(1000000)); > } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32484
:
144690
|
144706
|
147298
|
149798
|
149799
| 149800 |
149801
|
149802