Attachment 149855 Details for Bug 33354 – Bug 33354: Add error if related user open but user is missing

[patch] Bug 33354: Add error if related user open but user is missing

Bug-33354-Add-error-if-related-user-open-but-user-.patch (text/plain), 2.26 KB, created by Martin Renvoize (ashimema) on 2023-04-19 09:51:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-04-19 09:51:51 UTC

Size: 2.26 KB

patch

obsolete

>From bdba200fcf0ce408b5a2363887a17e41c7eff839 Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Wed, 29 Mar 2023 15:09:37 +0000
>Subject: [PATCH] Bug 33354: Add error if related user open but user is missing
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../prog/js/vue/components/ERM/AgreementsFormAdd.vue     | 9 +++++++++
> .../prog/js/vue/components/ERM/LicensesFormAdd.vue       | 9 +++++++++
> 2 files changed, 18 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue
>index bafe8ee118..2e6c971ca3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue
>@@ -318,6 +318,15 @@ export default {
>                     )
>                 )
>             }
>+            agreement.user_roles.forEach((user, i) => {
>+                if (user.patron_str === "") {
>+                    errors.push(
>+                        this.$__("Agreement user %s is missing a user").format(
>+                            i + 1
>+                        )
>+                    )
>+                }
>+            })
>             errors.forEach(function (e) {
>                 setWarning(e)
>             })
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesFormAdd.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesFormAdd.vue
>index 272253cadf..e3f88d10f6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesFormAdd.vue
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesFormAdd.vue
>@@ -224,6 +224,15 @@ export default {
>                     )
>                 )
>             }
>+            license.user_roles.forEach((user, i) => {
>+                if (user.patron_str === "") {
>+                    errors.push(
>+                        this.$__("License user %s is missing a user").format(
>+                            i + 1
>+                        )
>+                    )
>+                }
>+            })
>             errors.forEach(function (e) {
>                 setWarning(e)
>             })
>-- 
>2.40.0

Actions: View | Diff | Splinter Review

Attachments on bug 33354: 148931 | 148932 | 148933 | 149113 | 149114 | 149115 | 149854 | 149855 | 149856