Bugzilla – Attachment 149864 Details for
Bug 32721
Allow specifying UserCSS and UserJS at library level for the OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32721: Tidy up - duplicate fetching of userjs and css
Bug-32721-Tidy-up---duplicate-fetching-of-userjs-a.patch (text/plain), 3.29 KB, created by
Matt Blenkinsop
on 2023-04-19 10:46:12 UTC
(
hide
)
Description:
Bug 32721: Tidy up - duplicate fetching of userjs and css
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2023-04-19 10:46:12 UTC
Size:
3.29 KB
patch
obsolete
>From 910400487372efe17d901584d2dc0e79447edaf5 Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >Date: Fri, 27 Jan 2023 13:00:51 +0000 >Subject: [PATCH] Bug 32721: Tidy up - duplicate fetching of userjs and css > >Currently UserJS and UserCSS is injected into the template as a parameter through Auth.pm but is then fetched using Koha.Preference() in the template. This patch tidies this up by removing the parameters from Auth.pm > >Test plan as per first commit > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > C4/Auth.pm | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index adc1b5dd0d..d3e09ff281 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -562,7 +562,6 @@ sub get_template_and_user { > OpacHighlightedWords => C4::Context->preference("OpacHighlightedWords"), > OPACShelfBrowser => "" . C4::Context->preference("OPACShelfBrowser"), > OPACURLOpenInNewWindow => "" . C4::Context->preference("OPACURLOpenInNewWindow"), >- OPACUserCSS => "" . C4::Context->preference("OPACUserCSS"), > OpacAuthorities => C4::Context->preference("OpacAuthorities"), > opac_css_override => $ENV{'OPAC_CSS_OVERRIDE'}, > opac_search_limit => $opac_search_limit, >@@ -582,7 +581,6 @@ sub get_template_and_user { > OpacFavicon => C4::Context->preference("OpacFavicon"), > opaclanguagesdisplay => "" . C4::Context->preference("opaclanguagesdisplay"), > opacreadinghistory => C4::Context->preference("opacreadinghistory"), >- OPACUserJS => C4::Context->preference("OPACUserJS"), > opacuserlogin => "" . C4::Context->preference("opacuserlogin"), > OpenLibrarySearch => C4::Context->preference("OpenLibrarySearch"), > ShowReviewer => C4::Context->preference("ShowReviewer"), >@@ -1362,6 +1360,12 @@ sub checkauth { > OpacFavicon => C4::Context->preference("OpacFavicon"), > opacreadinghistory => C4::Context->preference("opacreadinghistory"), > opaclanguagesdisplay => C4::Context->preference("opaclanguagesdisplay"), >+ opacbookbag => "" . C4::Context->preference("opacbookbag"), >+ OpacCloud => C4::Context->preference("OpacCloud"), >+ OpacTopissue => C4::Context->preference("OpacTopissue"), >+ OpacAuthorities => C4::Context->preference("OpacAuthorities"), >+ OpacBrowser => C4::Context->preference("OpacBrowser"), >+ TagsEnabled => C4::Context->preference("TagsEnabled"), > OPACUserJS => C4::Context->preference("OPACUserJS"), > OPACUserCSS => C4::Context->preference("OPACUserCSS"), > intranetcolorstylesheet => C4::Context->preference("intranetcolorstylesheet"), >-- >2.37.1 (Apple Git-137.1)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32721
:
145731
|
145732
|
145733
|
145734
|
145735
|
145754
|
145759
|
146159
|
146160
|
146161
|
146162
|
146163
|
146164
|
147373
|
149860
|
149861
|
149862
|
149863
|
149864
|
149865
|
149866
|
150713
|
150724
|
150725
|
150726
|
150727
|
150728
|
150729
|
150730
|
150731
|
150732
|
150754
|
150755
|
150756
|
150757
|
150758
|
156157
|
156158
|
156159
|
156160
|
156161
|
156162
|
156163
|
156164
|
157335