Attachment 149893 Details for Bug 29822 – Bug 29822: Database and Preference description updates

[patch] Bug 29822: Database and Preference description updates

Bug-29822-Database-and-Preference-description-upda.patch (text/plain), 4.85 KB, created by Martin Renvoize (ashimema) on 2023-04-19 13:18:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-04-19 13:18:34 UTC

Size: 4.85 KB

patch

obsolete

>From 7c36570a9cf7395b636595d157aad8f279571ef9 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 10 Feb 2023 15:39:32 +0000
>Subject: [PATCH] Bug 29822: Database and Preference description updates
>
>---
> .../data/mysql/atomicupdate/bug_29822.pl      | 19 +++++++++++++++++++
> installer/data/mysql/mandatory/sysprefs.sql   |  2 +-
> .../en/modules/admin/preferences/patrons.pref |  2 +-
> 3 files changed, 21 insertions(+), 2 deletions(-)
> create mode 100644 installer/data/mysql/atomicupdate/bug_29822.pl
>
>diff --git a/installer/data/mysql/atomicupdate/bug_29822.pl b/installer/data/mysql/atomicupdate/bug_29822.pl
>new file mode 100644
>index 0000000000..742286bb9e
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug_29822.pl
>@@ -0,0 +1,19 @@
>+use Modern::Perl;
>+
>+return {
>+    bug_number => "29822",
>+    description => "Convert DefaultPatronSeachFields from csv to psv",
>+    up => sub {
>+        my ($args) = @_;
>+        my ($dbh, $out) = @$args{qw(dbh out)};
>+        # Do you stuffs here
>+        $dbh->do(q{
>+            UPDATE systempreferences
>+            SET
>+              value = REPLACE( value, ',', '|' )
>+            WHERE
>+              variable = 'DefaultPatronSearchFields'
>+        });
>+        say $out "Updated system preference 'DefaultPatronSearchFields";
>+    },
>+};
>diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql
>index e899c44ba5..7d227ae9cc 100644
>--- a/installer/data/mysql/mandatory/sysprefs.sql
>+++ b/installer/data/mysql/mandatory/sysprefs.sql
>@@ -183,7 +183,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('DefaultLongOverdueChargeValue', '', NULL, "Charge a lost item to the borrower's account when the LOST value of the item changes to n.", 'integer'),
> ('DefaultLongOverdueDays', '', NULL, "Set the LOST value of an item when the item has been overdue for more than n days.", 'integer'),
> ('DefaultLongOverdueLostValue', '', NULL, "Set the LOST value of an item to n when the item has been overdue for more than defaultlongoverduedays days.", 'integer'),
>-('DefaultPatronSearchFields',    'firstname,middle_name,surname,othernames,cardnumber,userid',NULL,'Comma separated list defining the default fields to be used during a patron search using the "standard" option. If empty Koha will default to "firstname,surname,othernames,cardnumber,userid". Additional fields added to this preference will be added as search options in the dropdown menu on the patron search page.','free'),
>+('DefaultPatronSearchFields',    'firstname|middle_name|surname|othernames|cardnumber|userid',NULL,'Pipe separated list defining the default fields to be used during a patron search using the "standard" option. If empty Koha will default to "firstname|surname|othernames|cardnumber|userid". Additional fields added to this preference will be added as search options in the dropdown menu on the patron search page.','free'),
> ('DefaultSaveRecordFileID','biblionumber','biblionumber|controlnumber','Defines whether the advanced cataloging editor will use the bibliographic record number or control number field to populate the name of the save file','Choice'),
> ('defaultSortField','relevance','relevance|popularity|call_number|pubdate|acqdate|title|author','Specify the default field used for sorting','Choice'),
> ('defaultSortOrder','dsc','asc|dsc|az|za','Specify the default sort order','Choice'),
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
>index 89ed406023..a8e6ca28e3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
>@@ -61,7 +61,7 @@ Patrons:
>            type: modalselect
>            source: borrowers
>            exclusions: anonymized|auth_method|autorenew_checkouts|date_renewed|dateenrolled|dateexpiry|lang|lastseen|login_attempts|overdrive_auth_token|password|password_expiration_date|primary_contact_method|gonenoaddress|lost|debarred|debarredcomment|branchcode|categorycode|flags|guarantorid|relationship|privacy|privacy_guarantor_checkouts|privacy_guarantor_fines|pronouns|secret|sms_provider_id|updated_on|checkprevcheckout
>-         - "If empty Koha will default to \"firstname,middle_name,surname,othernames,cardnumber,userid\". Additional fields added to this preference will be added as search options in the dropdown menu on the patron search page."
>+         - "If empty Koha will default to \"firstname|middle_name|surname|othernames|cardnumber|userid\". Additional fields added to this preference will be added as search options in the dropdown menu on the patron search page."
>      -
>          - "Show the following fields from the items database table as columns on the statistics tab on the patron record: "
>          - pref: StatisticsFields
>-- 
>2.40.0

Actions: View | Diff | Splinter Review

Attachments on bug 29822: 144814 | 144831 | 146430 | 146445 | 146488 | 146489 | 146490 | 146491 | 146492 | 147433 | 147434 | 147435 | 147436 | 147437 | 149890 | 149891 | 149892 | 149893 | 149894 | 151058 | 151059 | 151060 | 151061 | 151062 | 151064 | 151233 | 151234 | 151235 | 151236 | 151237 | 151238 | 153373 | 153374 | 153375 | 153376 | 153377 | 153378 | 153379 | 153380 | 153381 | 153382 | 153383 | 153384 | 153442 | 153443 | 153444 | 153445 | 153446 | 153447 | 154361 | 154362 | 154363 | 154364 | 154365 | 154366