Attachment 149926 Details for Bug 33484 – Bug 33484: Revert template change introduced in bug 22276

[patch] Bug 33484: Revert template change introduced in bug 22276

Bug-33484-Revert-template-change-introduced-in-bug.patch (text/plain), 2.10 KB, created by Martin Renvoize (ashimema) on 2023-04-20 10:25:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-04-20 10:25:30 UTC

Size: 2.10 KB

patch

obsolete

>From 3f5e1a3ddbc6d4e3443b5a6a7f61dc0298e238e4 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Tue, 11 Apr 2023 15:03:42 +0100
>Subject: [PATCH] Bug 33484: Revert template change introduced in bug 22276
>
>With the globalisation of the stateSave handling introduced by bug 22276
>we can remove the localised changes to the template in branches.tt
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>index a6aa3fe5fd..cbca3125c2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>@@ -478,8 +478,6 @@ Libraries &rsaquo; Administration &rsaquo; Koha
>     [% INCLUDE 'str/tinymce_i18n.inc' %]
>     <script>
>         var table_settings = [% TablesSettings.GetTableSettings( 'admin', 'libraries', 'libraries', 'json' ) | $raw %];
>-        var saved_table = localStorage.getItem("DataTables_libraries_/cgi-bin/koha/admin/branches.pl");
>-        var updated_settings = get_columns_saved_state(saved_table, table_settings);
> 
>         $(document).ready(function() {
> 
>@@ -490,7 +488,6 @@ Libraries &rsaquo; Administration &rsaquo; Koha
>                 },
>                 'embed': [ 'smtp_server' ],
>                 'emptyTable': '<div class="dialog message">'+_("There are no libraries defined.")+' <a href="/cgi-bin/koha/admin/branches.pl?op=add_form">'+_("Start defining libraries")+'</a>.</div>',
>-                "stateSave": true,
>                 "columnDefs": [ {
>                     "targets": [0,1,3,4,7,9,10,11,12,13,14,15,16],
>                     "render": function (data, type, row, meta) {
>@@ -659,7 +656,7 @@ Libraries &rsaquo; Administration &rsaquo; Koha
>                         "orderable": false
>                     }
>                 ]
>-            }, updated_settings);
>+            }, table_settings);
> 
>             [% UNLESS library %]
>                 $("#Aform").on("submit", function( event ) {
>-- 
>2.40.0

Actions: View | Diff | Splinter Review

Attachments on bug 33484: 149444 | 149445 | 149447 | 149448 | 149449 | 149925 | 149926 | 149927 | 149928 | 149929 | 149930 | 149974 | 149975 | 149976 | 149977 | 149978 | 149979 | 173443 | 173444 | 173445 | 173446 | 173447 | 173448 | 173449 | 173450 | 173451 | 173452 | 173453 | 173454 | 173455 | 173456 | 173457 | 173458 | 173459 | 173460 | 173461 | 173462 | 173463 | 173464 | 173465 | 173466 | 173467 | 173468 | 173469 | 173470 | 173471 | 173472 | 173473 | 173474 | 173475 | 173476 | 173477 | 173478 | 173479 | 173480 | 173481 | 173482 | 173483 | 173484 | 173485 | 173486 | 173546 | 173606 | 173607 | 173985 | 174219