Bugzilla – Attachment 149958 Details for
Bug 33571
Use template wrapper for breadcrumbs: Tools, part 2
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33571: Use template wrapper for breadcrumbs: Tools, part 2
Bug-33571-Use-template-wrapper-for-breadcrumbs-Too.patch (text/plain), 9.09 KB, created by
Owen Leonard
on 2023-04-20 13:24:04 UTC
(
hide
)
Description:
Bug 33571: Use template wrapper for breadcrumbs: Tools, part 2
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2023-04-20 13:24:04 UTC
Size:
9.09 KB
patch
obsolete
>From 3cb5a4fa5019744c21c8422e5da43c908b42314e Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 20 Apr 2023 13:15:29 +0000 >Subject: [PATCH] Bug 33571: Use template wrapper for breadcrumbs: Tools, part > 2 > >This patch updates several templates in the tools directory so that they >use the new WRAPPER for displaying breadcrumbs. > >To test, apply the patch and test each page and its variations. >Breadcrumbs should look correct, and each link should be correct. > >- Tools -> > - Batch patron deletion and anonymization > - Confirmation > - Results >- Cataloging -> > - Batch item modification > - Batch item deletion > - Batch record modification > - Results >--- > .../prog/en/modules/tools/batchMod-del.tt | 21 ++++----- > .../prog/en/modules/tools/batchMod-edit.tt | 29 ++++++------- > .../prog/en/modules/tools/batchMod.tt | 31 +++++-------- > .../tools/batch_record_modification.tt | 35 +++++++-------- > .../prog/en/modules/tools/cleanborrowers.tt | 43 +++++++------------ > 5 files changed, 62 insertions(+), 97 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt >index 48fe33da09..79908a3a0b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt >@@ -18,20 +18,15 @@ > [% END %] > > [% WRAPPER 'sub-header.inc' %] >-<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb"> >- <ol> >- <li> >- <a href="/cgi-bin/koha/mainpage.pl">Home</a> >- </li> >- <li> >+ [% WRAPPER breadcrumbs %] >+ [% WRAPPER breadcrumb_item %] > <a href="/cgi-bin/koha/cataloguing/cataloging-home.pl">Cataloging</a> >- </li> >- <li> >- <a href="#" aria-current="page">Batch item deletion</a> >- </li> >- </ol> >-</nav> >-[% END %] >+ [% END %] >+ [% WRAPPER breadcrumb_item bc_active= 1 %] >+ <span>Batch item deletion</span> >+ [% END %] >+ [% END #/ WRAPPER breadcrumbs %] >+[% END #/ WRAPPER sub-header.inc %] > > <div class="main container-fluid"> > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >index 26be2b1c84..f121aeb66c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt >@@ -14,24 +14,19 @@ > > <body id="tools_batchMod-edit" class="tools"> > [% WRAPPER 'header.inc' %] >- [% INCLUDE 'cat-search.inc' %] >-[% END %] >+ [% INCLUDE 'cat-search.inc' %] >+ [% END %] > >-[% WRAPPER 'sub-header.inc' %] >-<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb"> >- <ol> >- <li> >- <a href="/cgi-bin/koha/mainpage.pl">Home</a> >- </li> >- <li> >- <a href="/cgi-bin/koha/cataloguing/cataloging-home.pl">Cataloging</a> >- </li> >- <li> >- <a href="#" aria-current="page">Batch item modification</a> >- </li> >- </ol> >-</nav> >-[% END %] >+ [% WRAPPER 'sub-header.inc' %] >+ [% WRAPPER breadcrumbs %] >+ [% WRAPPER breadcrumb_item %] >+ <a href="/cgi-bin/koha/cataloguing/cataloging-home.pl">Cataloging</a> >+ [% END %] >+ [% WRAPPER breadcrumb_item bc_active= 1 %] >+ <span>Batch item modification</span> >+ [% END %] >+ [% END #/ WRAPPER breadcrumbs %] >+ [% END #/ WRAPPER sub-header.inc %] > > <div class="main container-fluid"> > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod.tt >index 3bca0ad225..df5a93df6a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod.tt >@@ -11,31 +11,22 @@ > [% END %] > > [% WRAPPER 'sub-header.inc' %] >-<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb"> >- <ol> >- <li> >- <a href="/cgi-bin/koha/mainpage.pl">Home</a> >- </li> >- <li> >+ [% WRAPPER breadcrumbs %] >+ [% WRAPPER breadcrumb_item %] > <a href="/cgi-bin/koha/cataloguing/cataloging-home.pl">Cataloging</a> >- </li> >+ [% END %] > > [% IF ( del ) %] >- <li> >- <a href="#" aria-current="page"> >- Batch item deletion >- </a> >- </li> >+ [% WRAPPER breadcrumb_item bc_active= 1 %] >+ <span>Batch item deletion</span> >+ [% END %] > [% ELSE %] >- <li> >- <a href="#" aria-current="page"> >- Batch item modification >- </a> >- </li> >+ [% WRAPPER breadcrumb_item bc_active= 1 %] >+ <span>Batch item modification</span> >+ [% END %] > [% END %] >- </ol> >-</nav> >-[% END %] >+ [% END #/ WRAPPER breadcrumbs %] >+[% END #/ WRAPPER sub-header.inc %] > > <div class="main container-fluid"> > <div class="row"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt >index ae80e0946b..1f31be64ef 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt >@@ -10,33 +10,28 @@ > > <body id="tools_batch_record_modification" class="tools"> > [% WRAPPER 'header.inc' %] >- [% INCLUDE 'cat-search.inc' %] >-[% END %] >+ [% INCLUDE 'cat-search.inc' %] >+ [% END %] > > [% WRAPPER 'sub-header.inc' %] >- <nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb"> >- <ol> >- <li> >- <a href="/cgi-bin/koha/mainpage.pl">Home</a> >- </li> >- <li> >+ [% WRAPPER breadcrumbs %] >+ [% WRAPPER breadcrumb_item %] > <a href="/cgi-bin/koha/cataloguing/cataloging-home.pl">Cataloging</a> >- </li> >+ [% END %] > [% IF view == 'form' %] >- <li> >- <a href="#" aria-current="page">Batch record modification</a> >- </li> >+ [% WRAPPER breadcrumb_item bc_active= 1 %] >+ <span>Batch record modification</span> >+ [% END %] > [% ELSE %] >- <li> >+ [% WRAPPER breadcrumb_item %] > <a href="/cgi-bin/koha/tools/batch_record_modification.pl">Batch record modification</a> >- </li> >- <li> >- <a href="#" aria-current="page">Results</a> >- </li> >+ [% END %] >+ [% WRAPPER breadcrumb_item bc_active= 1 %] >+ <span>Results</span> >+ [% END %] > [% END %] >- </ol> >- </nav> >- [% END %] >+ [% END #/ WRAPPER breadcrumbs %] >+ [% END #/ WRAPPER sub-header.inc %] > > <div class="main container-fluid"> > <div class="row"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt >index f90a017e64..3f7607347e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt >@@ -21,45 +21,34 @@ > [% END %] > > [% WRAPPER 'sub-header.inc' %] >-<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb"> >- <ol> >- <li> >- <a href="/cgi-bin/koha/mainpage.pl">Home</a> >- </li> >- <li> >+ [% WRAPPER breadcrumbs %] >+ [% WRAPPER breadcrumb_item %] > <a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a> >- </li> >+ [% END %] > > [% IF step == 1 %] >- <li> >- <a href="#" aria-current="page"> >- Batch patron deletion and anonymization >- </a> >- </li> >+ [% WRAPPER breadcrumb_item bc_active= 1 %] >+ <span>Batch patron deletion and anonymization</span> >+ [% END %] > [% ELSE %] >- <li> >+ [% WRAPPER breadcrumb_item %] > <a href="/cgi-bin/koha/tools/cleanborrowers.pl">Batch patron deletion and anonymization</a> >- </li> >+ [% END %] > [% END %] > > [% IF step == 2 %] >- <li> >- <a href="#" aria-current="page"> >- Confirm >- </a> >- </li> >+ [% WRAPPER breadcrumb_item bc_active= 1 %] >+ <span>Confirm</span> >+ [% END %] > [% END %] > > [% IF step == 3 %] >- <li> >- <a href="#" aria-current="page"> >- Finished >- </a> >- </li> >+ [% WRAPPER breadcrumb_item bc_active= 1 %] >+ <span>Finished</span> >+ [% END %] > [% END %] >- </ol> >-</nav> >-[% END %] >+ [% END #/ WRAPPER breadcrumbs %] >+[% END #/ WRAPPER sub-header.inc %] > > <div class="main container-fluid"> > <div class="row"> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33571
:
149958
|
150047
|
150074