Bugzilla – Attachment 150020 Details for
Bug 32894
Objects cache methods' result without invalidation
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32894: Remove incorrect caching from bundle_items
Bug-32894-Remove-incorrect-caching-from-bundleitem.patch (text/plain), 1.57 KB, created by
Martin Renvoize (ashimema)
on 2023-04-21 10:28:49 UTC
(
hide
)
Description:
Bug 32894: Remove incorrect caching from bundle_items
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-04-21 10:28:49 UTC
Size:
1.57 KB
patch
obsolete
>From 6857f881652f402b89d1a0e55ff7094e3a4b9c3b Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 21 Apr 2023 11:18:35 +0100 >Subject: [PATCH] Bug 32894: Remove incorrect caching from bundle_items > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Item.pm | 11 ++--------- > Koha/Schema/Result/Item.pm | 3 +++ > 2 files changed, 5 insertions(+), 9 deletions(-) > >diff --git a/Koha/Item.pm b/Koha/Item.pm >index 83b26dfe61..0df413629c 100644 >--- a/Koha/Item.pm >+++ b/Koha/Item.pm >@@ -1621,15 +1621,8 @@ Returns the items associated with this bundle > sub bundle_items { > my ($self) = @_; > >- if ( !$self->{_bundle_items_cached} ) { >- my $bundle_items = Koha::Items->search( >- { 'item_bundles_item.host' => $self->itemnumber }, >- { join => 'item_bundles_item' } ); >- $self->{_bundle_items} = $bundle_items; >- $self->{_bundle_items_cached} = 1; >- } >- >- return $self->{_bundle_items}; >+ my $rs = $self->_result->bundle_items; >+ return Koha::Items->_new_from_dbic($rs); > } > > =head3 is_bundle >diff --git a/Koha/Schema/Result/Item.pm b/Koha/Schema/Result/Item.pm >index fbadf85456..a98de28dd5 100644 >--- a/Koha/Schema/Result/Item.pm >+++ b/Koha/Schema/Result/Item.pm >@@ -968,6 +968,9 @@ __PACKAGE__->many_to_many( > "ordernumber", > ); > >+# Relationship with bundled items >+__PACKAGE__->many_to_many( bundle_items => 'item_bundles_hosts', 'item' ); >+ > __PACKAGE__->might_have( > "last_returned_by", > "Koha::Schema::Result::ItemsLastBorrower", >-- >2.40.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32894
:
147499
|
147500
|
147502
|
147503
|
150016
|
150017
|
150018
|
150019
|
150020
|
150021
|
150827
|
150828
|
150847
|
150848
|
150849
|
150850
|
150851
|
150852
|
150853
|
150854
|
150855
|
152086
|
152087
|
152088
|
152089
|
152090
|
152091
|
152092
|
152093
|
152094