Bugzilla – Attachment 15003 Details for
Bug 8682
quick slip: renewals do not appear on quick slips
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 8682 - Renewals do not appear on quick slips
Bug-8682---Renewals-do-not-appear-on-quick-slips.patch (text/plain), 1.56 KB, created by
Kyle M Hall (khall)
on 2013-02-01 13:35:39 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 8682 - Renewals do not appear on quick slips
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2013-02-01 13:35:39 UTC
Size:
1.56 KB
patch
obsolete
>From 8cee1c98081a94a953de4b198e0591623953df61 Mon Sep 17 00:00:00 2001 >From: Liz Rea <liz@catalyst.net.nz> >Date: Thu, 31 Jan 2013 14:53:29 +1300 >Subject: [PATCH] Bug 8682 - Renewals do not appear on quick slips > >To test: >Issue two books to a patron. >Do a renewal on one of them. >update the issuedate on the item that has been renewed to something before today (renewals on the same day will work even without this patch) >I did: select * from issues; >update issues set issuedate="2013-01-25 14:00:00" where itemnumber = 948; (itemnumber is variable depending on your test data.) > >Print a quick slip before the patch - the renewal will not show up as one of today's issues. >Print a quick slip after the patch - the renewal will show up as one of today's issues. > >If you need reasoning as to why a renewal should show up on the quick slip, think of it as a record of everything >a borrower did today, without the hassle of overdues. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Members.pm | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/C4/Members.pm b/C4/Members.pm >index f1136c2..a4aeacc 100644 >--- a/C4/Members.pm >+++ b/C4/Members.pm >@@ -2356,7 +2356,7 @@ sub IssueSlip { > > my $issueslist = GetPendingIssues($borrowernumber); > foreach my $it (@$issueslist){ >- if ((substr $it->{'issuedate'}, 0, 10) eq $now) { >+ if ((substr $it->{'issuedate'}, 0, 10) eq $now || (substr $it->{'lastreneweddate'}, 0, 10) eq $now) { > $it->{'now'} = 1; > } > elsif ((substr $it->{'date_due'}, 0, 10) le $now) { >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8682
:
14968
|
15003
|
15551