Bugzilla – Attachment 150080 Details for
Bug 33365
Add item type column to call number browser's results table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33365: (QA follow-up) Add check on item-level_itypes
Bug-33365-QA-follow-up-Add-check-on-item-levelityp.patch (text/plain), 2.22 KB, created by
Katrin Fischer
on 2023-04-22 13:46:35 UTC
(
hide
)
Description:
Bug 33365: (QA follow-up) Add check on item-level_itypes
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-04-22 13:46:35 UTC
Size:
2.22 KB
patch
obsolete
>From 20d18d474cc09a1e3be20f2774ebdb39aa6162a8 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sat, 22 Apr 2023 13:43:29 +0000 >Subject: [PATCH] Bug 33365: (QA follow-up) Add check on item-level_itypes > >With biblio level itemtypes you won't have any on the >item type level, so I feel like it will make sense >to hide the column here like we do in other spots. > >To test: >* pref at specific item = itemtype column shows >* pref at biblio level = no itemtype column > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../en/modules/cataloguing/value_builder/cn_browser.tt | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/cn_browser.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/cn_browser.tt >index 38f1896b08..0b9f2e1138 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/cn_browser.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/cn_browser.tt >@@ -1,6 +1,7 @@ > [% USE Asset %] > [% USE AuthorisedValues %] > [% USE ItemTypes %] >+[% USE Koha %] > [% SET footerjs = 1 %] > [% INCLUDE 'doc-head-open.inc' %] > <title>Call number browser › Cataloging › Koha</title> >@@ -51,7 +52,9 @@ > <th>Title</th> > <th>Library</th> > <th>Collection</th> >- <th>Item type</th> >+ [% IF Koha.Preference('item-level_itypes') %] >+ <th>Item type</th> >+ [% END %] > </tr></thead> > <tbody> > [% FOREACH cn_loo IN cn_loop %] >@@ -68,7 +71,9 @@ > </td> > <td style="background:[% cn_loo.background | html %];">[% cn_loo.branchname | html %]</td> > <td style="background:[% cn_loo.background | html %];">[% AuthorisedValues.GetByCode( 'CCODE', cn_loo.ccode ) | html %]</td> >- <td style="background:[% cn_loo.background | html %];">[% ItemTypes.GetDescription( cn_loo.itype ) | html %]</td> >+ [% IF Koha.Preference('item-level_itypes') %] >+ <td style="background:[% cn_loo.background | html %];">[% ItemTypes.GetDescription( cn_loo.itype ) | html %]</td> >+ [% END %] > </tr> > [% END %] > </tbody> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33365
:
148941
|
148942
|
149139
|
150079
| 150080