Attachment 150106 Details for Bug 32870 – Bug 32870: Fix cataloguing/value_builder/unimarc_field_225a_bis.pl

[patch] Bug 32870: Fix cataloguing/value_builder/unimarc_field_225a_bis.pl

Bug-32870-Fix-cataloguingvaluebuilderunimarcfield2.patch (text/plain), 1.46 KB, created by Katrin Fischer on 2023-04-22 22:20:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-04-22 22:20:55 UTC

Size: 1.46 KB

patch

obsolete

>From da1f9891a49f3d0a6d19ceaada7a7aa8046c9457 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Fri, 3 Feb 2023 11:58:55 +0100
>Subject: [PATCH] Bug 32870: Fix
> cataloguing/value_builder/unimarc_field_225a_bis.pl
>
>Use event parameter
>
>This is part of the refactoring happening in bug 30975
>
>Test plan:
>1. Verify that the plugin continues to work as before
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> cataloguing/value_builder/unimarc_field_225a_bis.pl | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/cataloguing/value_builder/unimarc_field_225a_bis.pl b/cataloguing/value_builder/unimarc_field_225a_bis.pl
>index 1ca62775a9..070c028ec0 100755
>--- a/cataloguing/value_builder/unimarc_field_225a_bis.pl
>+++ b/cataloguing/value_builder/unimarc_field_225a_bis.pl
>@@ -35,8 +35,9 @@ sub plugin_javascript {
>     my $function_name = $field_number;
>     my $res           = "
>     <script>
>-        function Clic$function_name(index) {
>-            window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_225a_bis.pl&index=\"+index,\"unimarc225a\",'width=500,height=400,toolbar=false,scrollbars=no');
>+        function Clic$function_name(event) {
>+            event.preventDefault();
>+            window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_225a_bis.pl&index=\"+event.data.id,\"unimarc225a\",'width=500,height=400,toolbar=false,scrollbars=no');
>         }
>     </script>
> ";
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32870: 146136 | 146803 | 150106