Bugzilla – Attachment 15011 Details for
Bug 9254
New option to block patrons from changing messaging preferences in OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 9254 - Problem with EnhancedMessagingPreferences - Followup - Rename pref to EnhancedMessagingPreferencesOPAC
SIGNED-OFF-Bug-9254---Problem-with-EnhancedMessagi.patch (text/plain), 5.38 KB, created by
Bernardo Gonzalez Kriegel
on 2013-02-01 14:19:49 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 9254 - Problem with EnhancedMessagingPreferences - Followup - Rename pref to EnhancedMessagingPreferencesOPAC
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2013-02-01 14:19:49 UTC
Size:
5.38 KB
patch
obsolete
>From 8e1203f28e3046799162800fe6df131e8a186deb Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 21 Dec 2012 11:11:56 -0500 >Subject: [PATCH] [SIGNED-OFF] Bug 9254 - Problem with > EnhancedMessagingPreferences - Followup - Rename pref to > EnhancedMessagingPreferencesOPAC > >If the new pref is named EnhancedMessagingPreferencesOPAC, it will show up adjacent to EnhancedMessagingPreferences > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> > >Comment: Works as described. But the patch only hides the link, >not disable the feature. If you refresh OPAC after unset >EnhancedMessagingPreferencesOPAC, you can still change >your messaging preferences. >--- > C4/Auth.pm | 2 +- > installer/data/mysql/sysprefs.sql | 2 +- > installer/data/mysql/updatedatabase.pl | 2 +- > .../prog/en/modules/admin/preferences/patrons.pref | 2 +- > koha-tmpl/opac-tmpl/prog/en/includes/usermenu.inc | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index 4fdbf74..66bb87b 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -316,7 +316,7 @@ sub get_template_and_user { > $template->param( > "BiblioDefaultView".C4::Context->preference("BiblioDefaultView") => 1, > EnhancedMessagingPreferences => C4::Context->preference('EnhancedMessagingPreferences'), >- OPACEnhancedMessagingPreferences => C4::Context->preference('OPACEnhancedMessagingPreferences'), >+ EnhancedMessagingPreferencesOPAC => C4::Context->preference('EnhancedMessagingPreferencesOPAC'), > GoogleJackets => C4::Context->preference("GoogleJackets"), > OpenLibraryCovers => C4::Context->preference("OpenLibraryCovers"), > KohaAdminEmailAddress => "" . C4::Context->preference("KohaAdminEmailAddress"), >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index a721d27..aa164f0 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -409,4 +409,4 @@ INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES(' > INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES ('SCOUserCSS', '', NULL, 'Add CSS to be included in the SCO module in an embedded <style> tag.', 'free'); > INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES ('SCOUserJS', '', NULL, 'Define custom javascript for inclusion in the SCO module', 'free'); > INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('RenewalSendNotices','0', NULL, '', 'YesNo'); >-INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES ('OPACEnhancedMessagingPreferences',1, 'Show the patrons messaging preferences page in the OPAC', NULL, 'YesNo'); >+INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES ('EnhancedMessagingPreferencesOPAC',1, 'Show the patrons messaging preferences page in the OPAC', NULL, 'YesNo'); >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index b2cc760..ac29dc6 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -6393,7 +6393,7 @@ if ( CheckVersion($DBversion) ) { > > $DBversion = "3.11.00.XXX"; > if (C4::Context->preference("Version") < TransformToNum($DBversion)) { >- $dbh->do("INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES ('OPACEnhancedMessagingPreferences',1, 'Show the patrons messaging preferences page in the OPAC', NULL, 'YesNo')"); >+ $dbh->do("INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES ('EnhancedMessagingPreferencesOPAC',1, 'Show the patrons messaging preferences page in the OPAC', NULL, 'YesNo')"); > print "Upgrade to $DBversion done (Bug 9254: Problem with EnhancedMessagingPreferences) \n"; > SetVersion ($DBversion); > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref >index c914dae..2d16a08 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref >@@ -62,7 +62,7 @@ Patrons: > no: "Don't allow" > - patrons to receive notices. Note that this only applies to certain kinds of notices. > - >- - pref: OPACEnhancedMessagingPreferences >+ - pref: EnhancedMessagingPreferencesOPAC > choices: > yes: Allow > no: "Don't allow" >diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/usermenu.inc b/koha-tmpl/opac-tmpl/prog/en/includes/usermenu.inc >index b48db08..b475d16 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/includes/usermenu.inc >+++ b/koha-tmpl/opac-tmpl/prog/en/includes/usermenu.inc >@@ -26,7 +26,7 @@ > [% IF ( suggestionsview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/opac-suggestions.pl">my purchase suggestions</a></li> > [% END %] > [% END %] >- [% IF ( EnhancedMessagingPreferences && OPACEnhancedMessagingPreferences ) %] >+ [% IF ( EnhancedMessagingPreferences && EnhancedMessagingPreferencesOPAC ) %] > [% IF ( messagingview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/opac-messaging.pl">my messaging</a></li> > [% END %] > [% IF ( virtualshelves ) %] >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9254
:
14199
|
14244
|
14246
|
15010
|
15011
|
15764
|
15765
|
20332
|
38122
|
38123
|
38124
|
38513
|
38514
|
38515
|
38516
|
38517