Attachment 150141 Details for Bug 33233 – Bug 33233: Don't allow disabled attribute to remain when using browser's back button

[patch] Bug 33233: Don't allow disabled attribute to remain when using browser's back button

Bug-33233-Dont-allow-disabled-attribute-to-remain-.patch (text/plain), 1.62 KB, created by Katrin Fischer on 2023-04-23 21:57:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-04-23 21:57:53 UTC

Size: 1.62 KB

patch

obsolete

>From b9b1211a63d94a462f0adff4bc9ecaa660f24d8a Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Tue, 11 Apr 2023 20:41:28 +0000
>Subject: [PATCH] Bug 33233: Don't allow disabled attribute to remain when
> using browser's back button
>
>To test:
>1. Go to OPAC advanced search and do a search using only one of the inputs.
>2. Once the search is complete use the browser's back button to return to the advanced search.
>3. Notice the unused inputs are disabled.
>4. Apply patch and try again. Now the inputs should not be disabled.
>
>Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
>index 3f0e874bfe..7e09f3911f 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
>@@ -459,6 +459,9 @@
> [% BLOCK jsinclude %]
> [% Asset.js("lib/jquery/plugins/jquery.deserialize.min.js") | $raw %]
> <script>
>+window.addEventListener('pageshow', function( e ){
>+    $('.form-control').prop('disabled' , false );
>+});
> $(document).ready(function() {
>     [% IF search_groups %]
>         function branch_limit() {
>@@ -559,6 +562,5 @@ $(document).ready(function() {
>         $(this).parent().parent().remove();
>         $('.search-term-row .search-term-input select[name="op"]').first().prop("disabled",true).hide();
>     });
>-
> </script>
> [% END %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33233: 149476 | 149701 | 150141