Bugzilla – Attachment 150145 Details for
Bug 32701
Self checkout help page lacks required I18N JavaScript
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32701: Fix I18N JavaScript libraries on self checkout help page
Bug-32701-Fix-I18N-JavaScript-libraries-on-self-ch.patch (text/plain), 2.08 KB, created by
David Nind
on 2023-04-23 23:30:46 UTC
(
hide
)
Description:
Bug 32701: Fix I18N JavaScript libraries on self checkout help page
Filename:
MIME Type:
Creator:
David Nind
Created:
2023-04-23 23:30:46 UTC
Size:
2.08 KB
patch
obsolete
>From cf32954e21cb4540b1ffd69cbc572f579b875444 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sun, 23 Apr 2023 21:16:52 +0000 >Subject: [PATCH] Bug 32701: Fix I18N JavaScript libraries on self checkout > help page > >The help page was missing the fixes from bug 28488. The missing >libraries are causing a JavaScript error on the page and likely >other issues. > >To test: >* Make sure WebBasedSelfCheck is activated and configured > Note: In ktd you don't need to configure anything, it's already set up. >* In the OPAC, go to: > /cgi-bin/koha/sco/sco-main.pl >* Click on the link to the help in the top right corner >* Verify you see the error in the console: > jQuery.Deferred exception: __ is not defined >* Apply patch >* Restart things >* Reload the page >* Veriy the errors are gone > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt | 7 +++++++ > 1 file changed, 7 insertions(+) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt >index b01c769dad..bc50e98507 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt >@@ -2,6 +2,7 @@ > [% USE Koha %] > [% USE Asset %] > [% USE KohaDates %] >+[% PROCESS 'i18n.inc' %] > [% INCLUDE 'doc-head-open.inc' %] > <title>Self checkout help › [% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Koha [% END %]</title> > <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> >@@ -12,8 +13,14 @@ > [% IF ( Koha.Preference('OPACUserCSS') ) %]<style>[% Koha.Preference('OPACUserCSS') | $raw %]</style>[% END %] > [% IF ( SCOUserCSS ) %]<style>[% SCOUserCSS | $raw %]</style>[% END %] > <script> >+ var Koha = {}; > function _(s) { return s } // dummy function for gettext > </script> >+[% IF lang && lang != 'en' %] >+ [% Asset.js(lang _ '/js/locale_data.js') | $raw %] >+[% END %] >+[% Asset.js('js/Gettext.js') | $raw %] >+[% Asset.js('js/i18n.js') | $raw %] > </head> > <body id="sco_help" class="sco"> > [% INCLUDE 'masthead-sco.inc' %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32701
:
150137
|
150145
|
150211