Bugzilla – Attachment 150174 Details for
Bug 33010
CheckinSlip doesn't return checkins if checkout library and checkin library differ
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33010: Do not filter checkins with logged in patrons branch in printslip.pl
Bug-33010-Do-not-filter-checkins-with-logged-in-pa.patch (text/plain), 1.80 KB, created by
Lucas Gass (lukeg)
on 2023-04-24 22:40:55 UTC
(
hide
)
Description:
Bug 33010: Do not filter checkins with logged in patrons branch in printslip.pl
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2023-04-24 22:40:55 UTC
Size:
1.80 KB
patch
obsolete
>From 6950417a19b5b3a87e0e96b3ab98695eaf5977a1 Mon Sep 17 00:00:00 2001 >From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Date: Mon, 20 Feb 2023 10:26:29 +0200 >Subject: [PATCH] Bug 33010: Do not filter checkins with logged in patrons > branch in printslip.pl > >If one tries to print checkin slip for checkins that >have been checked out from different branch, list >of checkins is empty. One has to change their branch >as checkout library to be able to print checkins. > >This happens because we filter (or rather search) patrons >old checkouts with logged in patrons branch. This patch >removes this search so that checkout are filtered using >just filter_by_todays_checkins. > >To test: >1. Checkout items for patron from branch A. >2. Switch to branch B and checkin items. >3. Print checkin slip. >=> Checkins list is empty. >4. Switch back to branch A. >5. Print checkin slip again. >=> Checkins are printed. >6. Apply this patch, restart services if needed. >7. Switch back to branch B and print checkin slip. >=> Checkins should now print. > >Sponsored-by: Koha-Suomi Oy >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > members/printslip.pl | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >diff --git a/members/printslip.pl b/members/printslip.pl >index 368d84cc7f..7971f83c67 100755 >--- a/members/printslip.pl >+++ b/members/printslip.pl >@@ -71,9 +71,7 @@ if ( $print eq 'checkinslip' ) { > my $checkinslip_branch = $session->param('branch') ? $session->param('branch') : $branch; > > # get today's checkins >- my @issue_ids = $patron->old_checkouts->search( { branchcode => $checkinslip_branch } ) >- ->filter_by_todays_checkins->get_column('issue_id'); >- >+ my @issue_ids = $patron->old_checkouts->filter_by_todays_checkins->get_column('issue_id'); > my %loops = ( > old_issues => \@issue_ids, > ); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33010
:
146943
|
150174
|
150429