Attachment 150191 Details for Bug 33412 – Bug 33412: Fix comparison when checking for overlay framework

[patch] Bug 33412: Fix comparison when checking for overlay framework

Bug-33412-Fix-comparison-when-checking-for-overlay.patch (text/plain), 1.48 KB, created by Nick Clemens (kidclamp) on 2023-04-25 12:09:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2023-04-25 12:09:54 UTC

Size: 1.48 KB

patch

obsolete

>From 1ccfca75ca5361b57a5fd803111177974632e3e3 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 5 Apr 2023 12:27:27 +0000
>Subject: [PATCH] Bug 33412: Fix comparison when checking for overlay framework
>
>TO test:
> 1 - Cataloging -> Export catalog data
> 2 - Export a record fom your catalog
> 3 - Cataloging -> Stage record for import
> 4 - Import the record, use Record matchign rule: KohaBiblio (999c)
> 5 - Stage, view batch
> 6 - Record should match the one that was exported
> 7 - When replacing record use this framework, choose a different value than current framework of record
> 8 - Import this batch
> 9 - View and edit record - note framework did not change
>10 - Apply patch
>11 - Restart all
>12 - Repeat 4-8
>13 - View and edit record, confirm framework has changed
>14 - Sign off
>---
> tools/manage-marc-import.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/manage-marc-import.pl b/tools/manage-marc-import.pl
>index e48b479029..83e8bcca0e 100755
>--- a/tools/manage-marc-import.pl
>+++ b/tools/manage-marc-import.pl
>@@ -90,7 +90,7 @@ if ($op eq "") {
> } elsif ($op eq "commit-batch") {
>     my $frameworkcode = $input->param('framework');
>     my $overlay_framework = $input->param('overlay_framework');
>-    $overlay_framework = undef if $overlay_framework = '_USE_ORIG';
>+    $overlay_framework = undef if $overlay_framework eq '_USE_ORIG';
>     try {
>         my $job_id = Koha::BackgroundJob::MARCImportCommitBatch->new->enqueue(
>             {
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33412: 149201 | 150191 | 150622 | 150804 | 150809 | 150817 | 150822