Attachment 150205 Details for Bug 32931 – Bug 32931: Fix translatability issues on 'new agreement' form

[patch] Bug 32931: Fix translatability issues on 'new agreement' form

Bug-32931-Fix-translatability-issues-on-new-agreem.patch (text/plain), 2.65 KB, created by Jonathan Druart on 2023-04-25 14:13:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2023-04-25 14:13:28 UTC

Size: 2.65 KB

patch

obsolete

>From 0cdcba71069ce4749729c83a5f72dddd15069dc5 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Sun, 16 Apr 2023 11:29:39 +0000
>Subject: [PATCH] Bug 32931: Fix translatability issues on 'new agreement' form
>
>This fixes the "Yes" and "No" options and "License info" placeholder.
>
>To get to the options:
>1. Enable the ERMModule system preference
>2. Go to E-resource management
>3. Click "Agreements"
>4. Click "New agreement"
>   --> Field "Is perpetual", options are Yes and No
>   --> At the bottom of the form "License info" with "License info"
>       within the input field
>5. Install (complete) language, verify those are not translated
>6. Apply patch
>7. Update po files
>8. Verify strings exist for this file, translate if necessary
>9. Re-install language
>10. Verify strings are now translated
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../prog/js/vue/components/ERM/AgreementsFormAdd.vue        | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue
>index 33f62f88006..784c12fffb7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue
>@@ -105,7 +105,7 @@
>                                         :value="true"
>                                         v-model="agreement.is_perpetual"
>                                     />
>-                                    Yes
>+                                    {{ $__("Yes") }}:
>                                 </label>
>                                 <label for="agreement_is_perpetual_no">
>                                     <input
>@@ -115,7 +115,7 @@
>                                         :value="false"
>                                         v-model="agreement.is_perpetual"
>                                     />
>-                                    No
>+                                    {{ $__("No") }}:
>                                 </label>
>                             </li>
>                             <li>
>@@ -137,7 +137,7 @@
>                                 <textarea
>                                     id="agreement_license_info"
>                                     v-model="agreement.license_info"
>-                                    placeholder="License info"
>+                                    :placeholder="$__('License info')"
>                                 />
>                             </li>
>                         </ol>
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 32931: 149727 | 149834 | 149835 | 150142 | 150143 | 150205 | 150206