Bugzilla – Attachment 150250 Details for
Bug 33590
WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to article-requests.tt
Bug-33590-Fix-DOM-id-name-for-tabs-after-WRAPPER-c.patch (text/plain), 2.64 KB, created by
Slava Shishkin
on 2023-04-26 17:40:21 UTC
(
hide
)
Description:
Bug 33590: Fix DOM id name for tabs after WRAPPER code added to article-requests.tt
Filename:
MIME Type:
Creator:
Slava Shishkin
Created:
2023-04-26 17:40:21 UTC
Size:
2.64 KB
patch
obsolete
>From 2aed60d104782ac92dbdadc99be822b63efb9984 Mon Sep 17 00:00:00 2001 >From: Slava Shishkin <slavashishkin@gmail.com> >Date: Wed, 26 Apr 2023 19:59:14 +0300 >Subject: [PATCH] Bug 33590: Fix DOM id name for tabs after WRAPPER code added > to article-requests.tt > >This commit fixed two cases: >1. Fixing "Select all" and "Clear all" links on the page. >2. Fixing the interaction with selected entries when switching between the "New" and "Pending" tabs. > >To test: >(Create article requests if they don't exist) > >Case 1: >1. Go to /cgi-bin/koha/circ/article-requests.pl and don't switch between tabs. >2. Click on "Select all" and verify that it's not working -- the checkboxes are not selected. >3. Activate any checkbox and click "Clear all" -- the checkbox is not cleared. >4. Apply the patch. >5. Restart the page and, without switching between tabs, repeat steps 2 and 3. Verify that it works now. > >Case 2: >1. Go to /cgi-bin/koha/circ/article-requests.pl. >2. Switch between tabs and leave "New" active. >3. Select any entry and delete or move it to another tab. >4. Verify that the entry remains in the table until the page reloads. >5. Apply the patch. >6. Restart the page and repeat steps 2 and 3. Make sure that everything works now. >--- > .../intranet-tmpl/prog/en/modules/circ/article-requests.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt >index af63e41876..88e0306baa 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt >@@ -521,15 +521,15 @@ > [% MACRO jsinclude BLOCK %] > [% INCLUDE 'datatables.inc' %] > <script> >- var active_tab = "#article-requests-requested"; >+ var active_tab = "#article-requests-requested_panel"; > var last_cancel_reason, requested_datatable, pending_datatable, processing_datatable, active_datatable; > $(document).ready(function() { > > $("#article-request-tabs a[data-toggle='tab']").on("shown.bs.tab", function (e) { > active_tab = e.target.hash; >- if( active_tab == "#article-requests-requested" ){ >+ if( active_tab == "#article-requests-requested_panel" ){ > active_datatable = requested_datatable; >- } else if( active_tab == "#article-requests-pending" ){ >+ } else if( active_tab == "#article-requests-pending_panel" ){ > active_datatable = pending_datatable; > } else { > active_datatable = processing_datatable; >-- >2.40.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33590
:
150250
|
150251
|
150298
|
150377
|
150457
|
150458
|
150459
|
150460
|
150549
|
150550
|
150551
|
150552