Attachment 150297 Details for Bug 33620 – Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty

[patch] Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty

Bug-33620-Dont-show-guarantor-info-on-details-page.patch (text/plain), 3.69 KB, created by PTFS Europe Sandboxes on 2023-04-27 13:21:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: PTFS Europe Sandboxes

Created: 2023-04-27 13:21:18 UTC

Size: 3.69 KB

patch

obsolete

>From 15e3bca9d4f7b6abd439202d051eb9f72417828b Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Wed, 26 Apr 2023 20:56:01 +0000
>Subject: [PATCH] Bug 33620: Don't show guarantor info on details page if
> borrowerRelationship is empty
>
>To test:
>1. Apply patch
>2. Have some values in borrowerRelationship.
>3. Go to a patron details page and see both 'Show checkouts to guarantor:' and 'Show charges to guarantor:'
>4. Now empty borrowerRelationship.
>5. Visit the patron detail page again and you should no longer see either of those fields.
>
>Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
>---
> .../prog/en/modules/members/moremember.tt | 35 ++++++++++---------
> 1 file changed, 18 insertions(+), 17 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>index e43206e987..a97a286c83 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
>@@ -181,24 +181,25 @@
> </li>
> [% END %]
> [% END %]
>- <li id="patron-privacyguarantor">
>- Show checkouts to guarantor
>- [% IF patron.privacy_guarantor_checkouts %]
>- Yes
>- [% ELSE %]
>- No
>- [% END %]
>- </li>
>-
>- <li id="patron-privacy_guarantor_fines">
>- Show charges to guarantor
>- [% IF patron.privacy_guarantor_fines %]
>- Yes
>- [% ELSE %]
>- No
>- [% END %]
>- </li>
>+ [% IF Koha.Preference("borrowerRelationship") %]
>+ <li id="patron-privacyguarantor">
>+ Show checkouts to guarantor
>+ [% IF patron.privacy_guarantor_checkouts %]
>+ Yes
>+ [% ELSE %]
>+ No
>+ [% END %]
>+ </li>
> 
>+ <li id="patron-privacy_guarantor_fines">
>+ Show charges to guarantor
>+ [% IF patron.privacy_guarantor_fines %]
>+ Yes
>+ [% ELSE %]
>+ No
>+ [% END %]
>+ </li>
>+ [% END %]
> [% IF guarantees %]
> <li>
> Guarantees:
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33620: 150257 | 150297 | 153188 | 155654