Bugzilla – Attachment 150395 Details for
Bug 25379
HTML in circulation notes doesn't show correctly on checkin
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25379: Add raw filter to circulation note on checkin page
Bug-25379-Add-raw-filter-to-circulation-note-on-ch.patch (text/plain), 2.20 KB, created by
Nick Clemens (kidclamp)
on 2023-04-28 16:08:55 UTC
(
hide
)
Description:
Bug 25379: Add raw filter to circulation note on checkin page
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2023-04-28 16:08:55 UTC
Size:
2.20 KB
patch
obsolete
>From 185f1e035cd9dce81af0033f19259b3d9db1e391 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Fri, 17 Mar 2023 21:36:23 +0000 >Subject: [PATCH] Bug 25379: Add raw filter to circulation note on checkin page > >This is a consistency patch: we already allow adding HTML tags >to the patron circulation note and the contents display >correctly in the patron account and in the patron search results >in the staff interface. But the HTML tags are printed on the >checkins page. > >To test: >* Add a circulation note including HTML tags to a patron > Example: <h1>This patron is great!</h1> >* Check an item out to this patron >* Verify that the note displays formatted in patron search results >* Verify that the note displays formatted in the patron record >* Return the item >* Verify the note shows the printed tags >* Apply patch >* Check item out again and check it in again >* Verify the note now displays correctly in list of checkins > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 8b686caf94..7c67dd2f38 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -1284,7 +1284,7 @@ > </td> > <td class="ci-note"> > [% IF ( riloo.patron.borrowernotes ) %] >- <p><span class="circ-hlt patron-note">[% riloo.patron.borrowernotes | html %]</span></p> >+ <p><span class="circ-hlt patron-note">[% riloo.patron.borrowernotes | $raw %]</span></p> > [% END %] > [% IF ( riloo.itemnote ) %] > <p><span class="circ-hlt item-note-public">[% riloo.itemnote | html %]</span></p> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25379
:
104375
|
148387
|
148496
| 150395 |
150396