Attachment 150399 Details for Bug 33398 – Bug 33398: Add primary_contact_method to display when triggering a waiting hold

[patch] Bug 33398: Add primary_contact_method to display when triggering a waiting hold

Bug-33398-Add-primarycontactmethod-to-display-when.patch (text/plain), 2.35 KB, created by Kyle M Hall (khall) on 2023-04-28 17:08:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2023-04-28 17:08:11 UTC

Size: 2.35 KB

patch

obsolete

>From e5ec92bf06a5336149ef78c25ef816771f8cdcf7 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Tue, 4 Apr 2023 15:43:41 +0000
>Subject: [PATCH] Bug 33398: Add primary_contact_method to display when
> triggering a waiting hold
>
>To test:
>1. Apply patch, yarn build
>2. Trigger a waiting hold for a patron that has a value for primary_contact_method
>3. Notice the modal now includes a line indicating the primary_contact_method.
>4. Trigger a hold for a patron without a primary_contact_method. Nothing should display.
>
>Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss  | 3 ++-
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 3 +++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>index ab0a8f9e3e..1f2009b210 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>@@ -483,7 +483,8 @@ form {
>             }
>         }
> 
>-        .notification_method {
>+        .notification_method,
>+        #main_contact_method    {
>             background-color: #FFE;
>             border: 1px solid #CCC;
>             border-radius: 5px;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index 8b686caf94..bbfb09fab8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -813,6 +813,9 @@
> 
>                                                         [% UNLESS ( transfertodo) %]
>                                                             [% INCLUDE display_bormessagepref %]
>+                                                            [% IF patron.primary_contact_method %]
>+                                                                <li id="main_contact_method">Main contact method: <span>[% patron.primary_contact_method | html %]</span></li>
>+                                                            [% END %]
>                                                         [% END %]
> 
>                                                         [% IF ( patron.is_debarred ) %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33398: 149136 | 149202 | 150399