Bugzilla – Attachment 150432 Details for
Bug 33634
Sidebar navigation links in system preferences not taking user to the clicked section
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33634: Correct anchors in system preference submenu
Bug-33634-Correct-anchors-in-system-preference-sub.patch (text/plain), 1.61 KB, created by
Aleisha Amohia
on 2023-04-30 21:24:00 UTC
(
hide
)
Description:
Bug 33634: Correct anchors in system preference submenu
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2023-04-30 21:24:00 UTC
Size:
1.61 KB
patch
obsolete
>From f027b1395b0502cbc328261b9f775099f27d0a0d Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 28 Apr 2023 15:53:19 +0000 >Subject: [PATCH] Bug 33634: Correct anchors in system preference submenu > >To test: >1. Go to Koha Administration -> Global system preferences >2. Go to a tab with a few headings like Circulation >3. Click on a heading in the sidebar navigation under Circulation that takes you a bit down the page, like Recalls >4. Notice this anchor link does not work, you are not taken to the recalls preferences >5. Apply patch >6. Try again, the links should take you to the proper place. > >Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> >Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc >index d59de66cf61..dbd8bce95e0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc >@@ -197,7 +197,7 @@ > <ul> > [% FOREACH LINE IN TAB.LINES %] > [% IF ( LINE.is_group_title ) %] >- <li><a class="pref_sublink" href="#[% LINE.title | $HtmlId %]">[% LINE.title | html %]</a></li> >+ <li><a class="pref_sublink" href="#[% TAB.tab_id | html %]_[% LINE.title | $HtmlId %]">[% LINE.title | html %]</a></li> > [% END %] > [% END %] > </ul> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33634
:
150393
|
150408
| 150432