Bugzilla – Attachment 150456 Details for
Bug 29664
Do not show voided payments in cash register statistics wizard
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29664: Do not show voided payments in cash_register_stats.pl
Bug-29664-Do-not-show-voided-payments-in-cashregis.patch (text/plain), 1.16 KB, created by
Kyle M Hall (khall)
on 2023-05-01 13:53:05 UTC
(
hide
)
Description:
Bug 29664: Do not show voided payments in cash_register_stats.pl
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2023-05-01 13:53:05 UTC
Size:
1.16 KB
patch
obsolete
>From a56fb07e3346cf078685fbcc1f210111d038182c Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 1 May 2023 09:50:24 -0400 >Subject: [PATCH] Bug 29664: Do not show voided payments in > cash_register_stats.pl > >Test Plan: >1) Set up your cash register >2) Take a payment >3) Void that payment >4) Verify the voided fee shows for the "All payments to the library" and > "Payment" transaction type filters >5) Apply this patch >6) Restart all the things! >7) Verify the voided fee no longer shows for the "All payments to the library" and > "Payment" transaction type filters >--- > reports/cash_register_stats.pl | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/reports/cash_register_stats.pl b/reports/cash_register_stats.pl >index c2b22f9db2..1861e02200 100755 >--- a/reports/cash_register_stats.pl >+++ b/reports/cash_register_stats.pl >@@ -82,6 +82,10 @@ if ($do_it) { > } > } > >+ if ( $transaction_type eq 'PAYMENT' || $transaction_type eq 'ACT' ) { >+ $whereTType .= q{ AND status != 'VOID' }; >+ } >+ > my $whereBranchCode = q{}; > if ($manager_branchcode ne 'ALL') { > $whereBranchCode = q{ AND m.branchcode = ?}; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29664
:
148689
|
148690
|
148691
|
148692
|
148693
|
148694
|
149102
|
150456
|
150580
|
152887
|
152888