Attachment 150463 Details for Bug 33611 – Bug 33611: Unit test

[patch] Bug 33611: Unit test

Bug-33611-Unit-test.patch (text/plain), 1.69 KB, created by David Nind on 2023-05-01 17:56:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-05-01 17:56:58 UTC

Size: 1.69 KB

patch

obsolete

>From 7a1de0fcf859436d52f957cc7fb261cfc8b5fe58 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 27 Apr 2023 13:02:24 +0000
>Subject: [PATCH] Bug 33611: Unit test
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> t/db_dependent/Reserves.t | 28 +++++++++++++++++++++++++++-
> 1 file changed, 27 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t
>index 3371c9539d..e64393154e 100755
>--- a/t/db_dependent/Reserves.t
>+++ b/t/db_dependent/Reserves.t
>@@ -17,7 +17,7 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 77;
>+use Test::More tests => 78;
> use Test::MockModule;
> use Test::Warn;
> 
>@@ -1735,3 +1735,29 @@ subtest 'CanItemBeReserved() tests' => sub {
> 
>     $schema->storage->txn_rollback;
> };
>+
>+subtest 'DefaultHoldExpiration tests' => sub {
>+    plan tests => 2;
>+    $schema->storage->txn_begin;
>+
>+    t::lib::Mocks::mock_preference( 'DefaultHoldExpirationdate', 1 );
>+    t::lib::Mocks::mock_preference( 'DefaultHoldExpirationdatePeriod', 365 );
>+    t::lib::Mocks::mock_preference( 'DefaultHoldExpirationUnitOfTime', 'days;' );
>+
>+    my $patron  = $builder->build_object( { class => 'Koha::Patrons' } );
>+    my $item    = $builder->build_sample_item();
>+
>+    my $reserve_id = AddReserve({
>+        branchcode     => $item->homebranch,
>+        borrowernumber => $patron->id,
>+        biblionumber   => $item->biblionumber,
>+    });
>+
>+    my $today = dt_from_string();
>+    my $hold = Koha::Holds->find( $reserve_id );
>+
>+    is( $hold->reservedate, $today->ymd, "Hold created today" );
>+    is( $hold->expirationdate, $today->add( days => 365)->ymd, "Reserve date set 1 year from today" );
>+
>+    $schema->txn_rollback;
>+};
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33611: 150223 | 150294 | 150295 | 150463 | 150464 | 150519 | 150520 | 150797 | 150798