Bugzilla – Attachment 150484 Details for
Bug 33645
koha-foreach always returns 1 if --chdir not specified
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33645: Make koha-foreach return 0 if it completes successfully
Bug-33645-Make-koha-foreach-return-0-if-it-complet.patch (text/plain), 931 bytes, created by
David Cook
on 2023-05-02 00:19:16 UTC
(
hide
)
Description:
Bug 33645: Make koha-foreach return 0 if it completes successfully
Filename:
MIME Type:
Creator:
David Cook
Created:
2023-05-02 00:19:16 UTC
Size:
931 bytes
patch
obsolete
>From 99addcd8325bf1a47911dd7db24d54049a0ca7ca Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Tue, 2 May 2023 00:16:30 +0000 >Subject: [PATCH] Bug 33645: Make koha-foreach return 0 if it completes > successfully > >This patch adds an "exit 0" to the end of koha-foreach, so that it >returns a successful exit code if it reaches the bottom of the script >without errors. > >Test plan: >0) `koha-foreach echo` >1) `echo $?` >2) Note that the exit status is 1 >3) Apply patch >4) `./debian/scripts/koha-foreach echo` >5) `echo $?` >6) Note that the exit status is 0 >--- > debian/scripts/koha-foreach | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/debian/scripts/koha-foreach b/debian/scripts/koha-foreach >index 2f5a150fcb..d2e98dd7de 100755 >--- a/debian/scripts/koha-foreach >+++ b/debian/scripts/koha-foreach >@@ -72,3 +72,5 @@ do > [ "$chdir" != "no" ] && cd "$starting_dir" > fi > done >+ >+exit 0 >-- >2.34.1
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=150484">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33645
:
150484
|
150492
|
150566