Attachment 150490 Details for Bug 31391 – Bug 31391: (follow-up) Fix number of tests and terminology

[patch] Bug 31391: (follow-up) Fix number of tests and terminology

Bug-31391-follow-up-Fix-number-of-tests-and-termin.patch (text/plain), 1.90 KB, created by David Nind on 2023-05-02 01:38:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-05-02 01:38:55 UTC

Size: 1.90 KB

patch

obsolete

>From 882d5b3ec369fe045bc3b6b315b32d5de0d376b1 Mon Sep 17 00:00:00 2001
>From: David Nind <david@davidnind.com>
>Date: Mon, 21 Nov 2022 21:57:36 +0000
>Subject: [PATCH] Bug 31391: (follow-up) Fix number of tests and terminology
>
>Fixed two items:
>- Number of tests: changed to 77 (from 76), tests now pass
>- Terminology: changed message when attempting to place recalls
>from the staff interface when RecallsInterface in set to the OPAC
>only (staff client should be staff interface)
>
>Signed-off-by: David <david@davidnind.com>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt | 2 +-
> t/db_dependent/Holds.t                                     | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt
>index f2d3c297a5..2fa07dff87 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt
>@@ -192,7 +192,7 @@
> 
>         [% IF Koha.Preference('RecallsInterface') == 'opac' %]
>         <div class="dialog alert">
>-            Due to the <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=RecallsInterface">RecallsInterface system preference</a>, recalls cannot be placed through the staff client.
>+            Due to the <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=RecallsInterface">RecallsInterface</a> system preference, recalls cannot be placed through the staff interface.
>         </div>
>         [% ELSE %]
> 
>diff --git a/t/db_dependent/Holds.t b/t/db_dependent/Holds.t
>index f2b040adbf..8d00c1dcd6 100755
>--- a/t/db_dependent/Holds.t
>+++ b/t/db_dependent/Holds.t
>@@ -7,7 +7,7 @@ use t::lib::TestBuilder;
> 
> use C4::Context;
> 
>-use Test::More tests => 76;
>+use Test::More tests => 77;
> use Test::Exception;
> 
> use MARC::Record;
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31391: 139442 | 139443 | 139444 | 139446 | 139642 | 139643 | 139644 | 139645 | 141474 | 142594 | 143155 | 144104 | 144105 | 144131 | 144132 | 144133 | 144134 | 144135 | 144136 | 147581 | 147582 | 150485 | 150486 | 150487 | 150488 | 150489 | 150490 | 150491 | 156995 | 156996 | 156997 | 156998 | 156999 | 157000 | 157001 | 158691 | 158692 | 158693 | 158694 | 158695 | 158825 | 158826 | 158827 | 158828 | 158829 | 158830 | 158831 | 158832 | 172166 | 172167 | 172168 | 172169 | 172170 | 172171 | 172172 | 172173 | 172174 | 172175 | 173839 | 173840 | 173841 | 173842 | 173843 | 173844 | 173845 | 173846 | 173847 | 174396 | 174822 | 174823 | 174824 | 174825 | 174826 | 174827 | 174828 | 174829 | 174830 | 174831