Attachment 150568 Details for Bug 32921 – Bug 32921: Honor SelfCheckTimeout when modal is open

[patch] Bug 32921: Honor SelfCheckTimeout when modal is open

Bug-32921-Honor-SelfCheckTimeout-when-modal-is-ope.patch (text/plain), 1.45 KB, created by Jonathan Druart on 2023-05-03 09:34:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2023-05-03 09:34:28 UTC

Size: 1.45 KB

patch

obsolete

>From 5c081186f43b6f747e81a443bbde9bfdf28ce698 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Wed, 8 Feb 2023 23:28:59 +0000
>Subject: [PATCH] Bug 32921: Honor SelfCheckTimeout when modal is open
>
>To test:
>1. Set the 'SelfCheckTimeout' system preference to something low for testing.
>2. Make sure 'SelfCheckReceiptPrompt' is set to 'Show'.
>3. Log in to SCO and press finish but leave the modal open.
>4. Wait until the 'SelfCheckTimeout' time has expired, nothing happens.
>5. Apply patch and try again. You should be logged out when SelfCheckTimeout expires.
>
>Signed-off-by: Marius Mandrescu <marius.mandrescu@inLibro.com>
>
>JD amended patch - fix indentation
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
>index a157e86cc68..7f2b299aee2 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
>@@ -526,6 +526,7 @@
>                             location.href = '/cgi-bin/koha/sco/sco-main.pl?op=logout';
>                         }
>                     })
>+                sco_init();
>                 [% ELSE %]
>                     location.href = '/cgi-bin/koha/sco/sco-main.pl?op=logout';
>                 [% END %]
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 32921: 146414 | 149779 | 150568