Attachment 150631 Details for Bug 33069 – Bug 33069: Fix error in MARC download for OPAC lists

[patch] Bug 33069: Fix error in MARC download for OPAC lists

Bug-33069-Fix-error-in-MARC-download-for-OPAC-list.patch (text/plain), 1.55 KB, created by Magnus Enger on 2023-05-04 07:55:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Magnus Enger

Created: 2023-05-04 07:55:45 UTC

Size: 1.55 KB

patch

obsolete

>From 53442b89cc79f550c4cd0b9f7f7ce8dc0c4b5548 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Wed, 3 May 2023 21:28:30 +0000
>Subject: [PATCH] Bug 33069: Fix error in MARC download for OPAC lists
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>There was a code typo causing an error when you tried
>to download a list in MARC format:
>
>Not a CODE reference at /kohadevbox/koha/opac/opac-downloadshelf.pl line 93
>
>To test:
>* In the OPAC: create a new list, public or private, with some records
>* Open the list
>* Try to download the list as MARC
>* Verify you get an error
>* Apply patch
>* Verify you now get the expected download file
>* Sign off :)
>
>Co-authored-by: KÃ©vin AYRAULT <kevin.ayrault87@gmail.com>
>Signed-off-by: Magnus Enger <magnus@libriotech.no>
>Nasty error before the patch; nice, tasty MARC download after.
>---
> opac/opac-downloadshelf.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/opac/opac-downloadshelf.pl b/opac/opac-downloadshelf.pl
>index 2414d1566a..ea81c1e7ce 100755
>--- a/opac/opac-downloadshelf.pl
>+++ b/opac/opac-downloadshelf.pl
>@@ -90,7 +90,7 @@ if ( $shelf and $shelf->can_be_viewed( $borrowernumber ) ) {
>                 my $biblionumber = $content->biblionumber;
> 
>                 my $biblio = Koha::Biblios->find($biblionumber);
>-                my $record = $biblio->metadata->record->(
>+                my $record = $biblio->metadata->record(
>                     {
>                         embed_items => 1,
>                         opac        => 1,
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 33069: 150619 | 150631 | 150807 | 150835