Attachment 150648 Details for Bug 33672 – Bug 33672: Don't show item group holds on OPAC if not enabled

[patch] Bug 33672: Don't show item group holds on OPAC if not enabled

Bug-33672-Dont-show-item-group-holds-on-OPAC-if-no.patch (text/plain), 1.98 KB, created by Nick Clemens (kidclamp) on 2023-05-04 11:17:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2023-05-04 11:17:40 UTC

Size: 1.98 KB

patch

obsolete

>From c5210b38209442a3ef5f7b8a2ad9beae5417fb56 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 4 May 2023 11:14:29 +0000
>Subject: [PATCH] Bug 33672: Don't show item group holds on OPAC if not enabled
>
>This patch adds a check of the syspref 'EnbaleItemGroupHolds' to the
>opac request form
>
>To test:
>1 - Enable 'EnableItemGroups' system preference
>2 - On staff client, view a record details
>3 - Go to 'Item groups' tab, add a enw group
>4 - On holdings tab, select one or more items and add to group
>5 - View record in OPAC
>6 - PLace a hold
>7 - Note group option is visible
>8 - Apply patch
>9 - Refresh, no group option
>10 - Enable 'EnableItemGroupHolds' system preference
>11 - Refresh opac page, note group option is visible
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>index 9a6a452a08..0b04429b5b 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
>@@ -315,7 +315,7 @@
>                                                 [% END %]
> 
>                                                 [% UNLESS bibitemloo.forced_hold_level && ( bibitemloo.forced_hold_level == 'item' || bibitemloo.forced_hold_level == 'record' ) %]
>-                                                    [% IF bibitemloo.object.item_groups %]
>+                                                    [% IF Koha.Preference('EnableItemGroupHolds') && bibitemloo.object.item_groups %]
>                                                         <li>
>                                                             <label for="itemtype">Request specific item group:</label>
>                                                             <select name="item_group_id_[% bibitemloo.biblionumber | html %]" id="item_group_id_[% bibitemloo.biblionumber | html %]">
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33672: 150648 | 150698