Attachment 150788 Details for Bug 22440 – Bug 22440: (follow-up) Nothing is forever

[patch] Bug 22440: (follow-up) Nothing is forever

Bug-22440-follow-up-Nothing-is-forever.patch (text/plain), 1.81 KB, created by Tomás Cohen Arazi (tcohen) on 2023-05-05 19:05:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2023-05-05 19:05:43 UTC

Size: 1.81 KB

patch

obsolete

>From 5ed701ab58084b5a618a561cad83571d2266d8b6 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 5 May 2023 15:53:31 -0300
>Subject: [PATCH] Bug 22440: (follow-up) Nothing is forever
>
>This patch picks (yet) another class for testing purposes. The class
>needs to not implement to_api() and to_api_mapping().
>---
> t/db_dependent/Koha/Object.t | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/t/db_dependent/Koha/Object.t b/t/db_dependent/Koha/Object.t
>index a49a3784c2b..d71a21d735f 100755
>--- a/t/db_dependent/Koha/Object.t
>+++ b/t/db_dependent/Koha/Object.t
>@@ -270,8 +270,8 @@ subtest "to_api() tests" => sub {
>     ok( !exists $api_city->{postal_code}, 'Attribute removed' );
> 
>     # Pick a class that won't have a mapping for the API
>-    my $illrequest = $builder->build_object({ class => 'Koha::Illrequests' });
>-    is_deeply( $illrequest->to_api, $illrequest->TO_JSON, 'If no overloaded to_api_mapping method, return TO_JSON' );
>+    my $action_log = $builder->build_object({ class => 'Koha::ActionLogs' });
>+    is_deeply( $action_log->to_api, $action_log->TO_JSON, 'If no overloaded to_api_mapping method, return TO_JSON' );
> 
>     my $biblio = $builder->build_sample_biblio();
>     my $item = $builder->build_sample_item({ biblionumber => $biblio->biblionumber });
>@@ -545,8 +545,8 @@ subtest "to_api_mapping() tests" => sub {
> 
>     $schema->storage->txn_begin;
> 
>-    my $illrequest = $builder->build_object({ class => 'Koha::Illrequests' });
>-    is_deeply( $illrequest->to_api_mapping, {}, 'If no to_api_mapping present, return empty hashref' );
>+    my $action_log = $builder->build_object({ class => 'Koha::ActionLogs' });
>+    is_deeply( $action_log->to_api_mapping, {}, 'If no to_api_mapping present, return empty hashref' );
> 
>     $schema->storage->txn_rollback;
> };
>-- 
>2.40.1

Actions: View | Diff | Splinter Review

Attachments on bug 22440: 150715 | 150716 | 150717 | 150718 | 150719 | 150720 | 150721 | 150722 | 150723 | 150788 | 150789