Attachment 15080 Details for Bug 9432 – Bug 9432: Plack changes for acqui/addorderiso2409.pl

[patch] Bug 9432: Plack changes for acqui/addorderiso2409.pl

Bug-9432-Plack-changes-for-acquiaddorderiso2409pl.patch (text/plain), 1.55 KB, created by Mirko Tietgen on 2013-02-05 21:39:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mirko Tietgen

Created: 2013-02-05 21:39:32 UTC

Size: 1.55 KB

patch

obsolete

>From 33fc7930fce6cba0f48c81e8fec363c1765fd753 Mon Sep 17 00:00:00 2001
>From: Jared Camins-Esakov <jcamins@cpbibliography.com>
>Date: Fri, 18 Jan 2013 19:48:20 -0500
>Subject: [PATCH] Bug 9432: Plack changes for acqui/addorderiso2409.pl
>
>Without this patch, after selecting the file I want to add acquisitions
>from, Plack explodes. With this patch, it works.
>
>To test without Plack:
>1) Apply patch.
>2) Try adding an order item from a staged file.
>3) If it works, there are no regressions from the patch.
>
>To test with Plack:
>1) Try adding an order item from a staged file. It will fail.
>2) Apply patch.
>3) Try adding an order item from a staged file.
>3) If it works, the patch is successful.
>
>Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
>Fixes Plack, does not break Apache. Works as expected.
>---
> acqui/addorderiso2709.pl |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/acqui/addorderiso2709.pl b/acqui/addorderiso2709.pl
>index 0e0670f..abfb870 100755
>--- a/acqui/addorderiso2709.pl
>+++ b/acqui/addorderiso2709.pl
>@@ -425,11 +425,11 @@ sub batch_info {
>                                               'current_matcher_description' => $matcher->description());
>         }
>     }
>-    add_matcher_list($batch->{'matcher_id'});
>+    add_matcher_list($batch->{'matcher_id'}, $template);
> }
> 
> sub add_matcher_list {
>-    my $current_matcher_id = shift;
>+    my ($current_matcher_id, $template) = @_;
>     my @matchers = C4::Matcher::GetMatcherList();
>     if (defined $current_matcher_id) {
>         for (my $i = 0; $i <= $#matchers; $i++) {
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 9432: 14722 | 15080 | 15100