Attachment 150802 Details for Bug 33613 – Bug 33613: Use prop() to evaluate checkbox

[patch] Bug 33613: Use prop() to evaluate checkbox

Bug-33613-Use-prop-to-evaluate-checkbox.patch (text/plain), 1.47 KB, created by Hinemoea Viault on 2023-05-08 16:08:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Hinemoea Viault

Created: 2023-05-08 16:08:35 UTC

Size: 1.47 KB

patch

obsolete

>From f9d1963d577cc6fdc886012c3c92343d0932fc04 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Tue, 25 Apr 2023 23:11:17 +0000
>Subject: [PATCH] Bug 33613: Use prop() to evaluate checkbox
>
>To test:
>1. Have an item with a replacement cost checked out to a patron
>2. Set the ClaimReturnedChargeFee sys pref to "Ask if a lost fee should be charged"
>3. Make a claim and check the box for charging.
>4. Claim happens but no charge occurs.
>5. Apply patch and try again.
>6. A charge should now occur.
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Hinemoea Viault <hinemoea.viault@inlibro.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/modal-claims.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/modal-claims.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/modal-claims.inc
>index 59cc8a6ad2..be16faa851 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/modal-claims.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/modal-claims.inc
>@@ -63,7 +63,7 @@
>     $(document).on("click", '#claims-returned-modal-btn-submit', function(e){
>         let itemnumber = $('#claims-returned-itemnumber').val();
>         let notes = $('#claims-returned-notes').val();
>-        let fee = $('#claims-returned-charge-lost-fee').attr('checked') ? true : false;
>+        let fee = $('#claims-returned-charge-lost-fee').prop('checked') ? true : false;
> 
>         $('#claims-returned-modal').modal('hide');
> 
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 33613: 150237 | 150252 | 150802 | 150829