Attachment 150825 Details for Bug 33671 – [PUSHED] Bug 33671: Update POD, remove unneeded check in relationship->guarantor

[patch] [PUSHED] Bug 33671: Update POD, remove unneeded check in relationship->guarantor

Bug-33671-Update-POD-remove-unneeded-check-in-rela.patch (text/plain), 2.07 KB, created by Jonathan Druart on 2023-05-09 08:24:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2023-05-09 08:24:26 UTC

Size: 2.07 KB

patch

obsolete

>From 800c9305244bc79092b8893a28c2972801b580df Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 4 May 2023 07:06:07 +0000
>Subject: [PATCH] Bug 33671: Update POD, remove unneeded check in
> relationship->guarantor
>
>[1] Update POD for $patron->guarantor_relationships
>[2] Remove check from Patron::Relationship->guarantor
>
>Test plan:
>Run t/db_dependent/Koha/Patron.t
>Run t/db_dependent/Patron/Relationships.t
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> Koha/Patron.pm              | 6 +++---
> Koha/Patron/Relationship.pm | 6 +-----
> 2 files changed, 4 insertions(+), 8 deletions(-)
>
>diff --git a/Koha/Patron.pm b/Koha/Patron.pm
>index f0e17342171..d7c2d47b429 100644
>--- a/Koha/Patron.pm
>+++ b/Koha/Patron.pm
>@@ -471,9 +471,9 @@ Returns Koha::Patron::Relationships object for this patron's guarantors
> 
> Returns the set of relationships for the patrons that are guarantors for this patron.
> 
>-This is returned instead of a Koha::Patron object because the guarantor
>-may not exist as a patron in Koha. If this is true, the guarantors name
>-exists in the Koha::Patron::Relationship object and will have no guarantor_id.
>+Note that a guarantor should exist as a patron in Koha; it was not possible
>+to add them without a guarantor_id in the interface for some time. Bug 30472
>+restricts it on db level.
> 
> =cut
> 
>diff --git a/Koha/Patron/Relationship.pm b/Koha/Patron/Relationship.pm
>index 88ede2cc519..544f4aaa0c7 100644
>--- a/Koha/Patron/Relationship.pm
>+++ b/Koha/Patron/Relationship.pm
>@@ -73,15 +73,12 @@ sub store {
> 
> =head3 guarantor
> 
>-Returns the Koha::Patron object for the guarantor, if there is one
>+Returns the Koha::Patron object for the guarantor
> 
> =cut
> 
> sub guarantor {
>     my ( $self ) = @_;
>-
>-    return unless $self->guarantor_id;
>-
>     return Koha::Patrons->find( $self->guarantor_id );
> }
> 
>@@ -93,7 +90,6 @@ Returns the Koha::Patron object for the guarantee
> 
> sub guarantee {
>     my ( $self ) = @_;
>-
>     return Koha::Patrons->find( $self->guarantee_id );
> }
> 
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 33671: 150629 | 150630 | 150824 | 150825 | 153367 | 153533 | 153536