Attachment 150864 Details for Bug 33576 – Bug 33576: (QA follow-up) Polish comment, typo

[patch] Bug 33576: (QA follow-up) Polish comment, typo

Bug-33576-QA-follow-up-Polish-comment-typo.patch (text/plain), 1.74 KB, created by Marcel de Rooy on 2023-05-09 13:02:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2023-05-09 13:02:02 UTC

Size: 1.74 KB

patch

obsolete

>From d7f28612418ce4045bb714d3c0f8bdb3a66b040b Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 24 Apr 2023 09:27:43 +0000
>Subject: [PATCH] Bug 33576: (QA follow-up) Polish comment, typo
>Content-Type: text/plain; charset=utf-8
>
>No test plan.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> C4/ImportBatch.pm                        | 3 +--
> Koha/BackgroundJob/UpdateElasticIndex.pm | 2 +-
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/C4/ImportBatch.pm b/C4/ImportBatch.pm
>index a200876bb2..65c0743ffd 100644
>--- a/C4/ImportBatch.pm
>+++ b/C4/ImportBatch.pm
>@@ -716,7 +716,7 @@ sub BatchCommitRecords {
> 
>     SetImportBatchStatus($batch_id, 'imported');
> 
>-    # Moved final commit to the end
>+    # final commit should be before Elastic background indexing in order to find job data
>     $schema->txn_commit;
> 
>     if ( @biblio_ids ) {
>@@ -724,7 +724,6 @@ sub BatchCommitRecords {
>         $indexer->index_records( \@biblio_ids, "specialUpdate", "biblioserver" );
>     }
> 
>-
>     return ($num_added, $num_updated, $num_items_added, $num_items_replaced, $num_items_errored, $num_ignored);
> }
> 
>diff --git a/Koha/BackgroundJob/UpdateElasticIndex.pm b/Koha/BackgroundJob/UpdateElasticIndex.pm
>index 10ff70a686..1439482dda 100644
>--- a/Koha/BackgroundJob/UpdateElasticIndex.pm
>+++ b/Koha/BackgroundJob/UpdateElasticIndex.pm
>@@ -29,7 +29,7 @@ Koha::BackgroundJob::UpdateElasticIndex - Update Elastic index
> This is a subclass of Koha::BackgroundJob.
> 
> While most background jobs provide a I<process> method, the ES indexing has its
>-own dedicated worker: misc/workers/es_index_daemon.pl
>+own dedicated worker: misc/workers/es_indexer_daemon.pl
> 
> That worker handles all job processing.
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33576: 149971 | 150147 | 150591 | 150592 | 150863 | 150864