Bugzilla – Attachment 150880 Details for
Bug 30979
Add ability for OPAC users to checkout to themselves
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30979: Unit tests - Availability endpoint
Bug-30979-Unit-tests---Availability-endpoint.patch (text/plain), 7.43 KB, created by
Martin Renvoize (ashimema)
on 2023-05-09 14:52:06 UTC
(
hide
)
Description:
Bug 30979: Unit tests - Availability endpoint
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-05-09 14:52:06 UTC
Size:
7.43 KB
patch
obsolete
>From 908c0db05df4bef090b2a2f39c20bdf47d47f526 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 27 Apr 2023 17:03:15 +0100 >Subject: [PATCH] Bug 30979: Unit tests - Availability endpoint > >This patch adds unit tests for the new checkout availability endpoint >we're going to introduce in this patchset. > >Signed-off-by: Helen Oliver <HOliver@tavi-port.ac.uk> >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > t/db_dependent/api/v1/checkouts.t | 180 +++++++++++++++++++++++++++++- > 1 file changed, 178 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/api/v1/checkouts.t b/t/db_dependent/api/v1/checkouts.t >index 8c58dd217c..b07ec0e838 100755 >--- a/t/db_dependent/api/v1/checkouts.t >+++ b/t/db_dependent/api/v1/checkouts.t >@@ -17,7 +17,7 @@ > > use Modern::Perl; > >-use Test::More tests => 99; >+use Test::More tests => 101; > use Test::MockModule; > use Test::Mojo; > use t::lib::Mocks; >@@ -26,7 +26,7 @@ use t::lib::TestBuilder; > use DateTime; > > use C4::Context; >-use C4::Circulation qw( AddIssue AddReturn ); >+use C4::Circulation qw( AddIssue AddReturn CanBookBeIssued ); > > use Koha::Database; > use Koha::DateUtils qw( dt_from_string output_pref ); >@@ -232,3 +232,179 @@ $t->get_ok( "//$userid:$password@/api/v1/checkouts/" . $issue2->issue_id . "/all > current_renewals => 1, > error => 'too_many' > }); >+ >+$schema->storage->txn_rollback; >+ >+subtest 'get_availability' => sub { >+ >+ plan tests => 27; >+ >+ $schema->storage->txn_begin; >+ my $librarian = $builder->build_object( >+ { >+ class => 'Koha::Patrons', >+ value => { flags => 2 } >+ } >+ ); >+ my $password = 'thePassword123'; >+ $librarian->set_password( { password => $password, skip_validation => 1 } ); >+ my $userid = $librarian->userid; >+ >+ my $patron = $builder->build_object( >+ { >+ class => 'Koha::Patrons', >+ value => { flags => 0 } >+ } >+ ); >+ my $unauth_password = 'thePassword000'; >+ $patron->set_password( >+ { password => $unauth_password, skip_validattion => 1 } ); >+ my $unauth_userid = $patron->userid; >+ my $patron_id = $patron->borrowernumber; >+ >+ my $branchcode = $builder->build( { source => 'Branch' } )->{branchcode}; >+ >+ my $item1 = $builder->build_sample_item; >+ my $item1_id = $item1->id; >+ >+ my %issuingimpossible = (); >+ my %needsconfirmation = (); >+ my %alerts = (); >+ my %messages = (); >+ my $mocked_circ = Test::MockModule->new('C4::Circulation'); >+ $mocked_circ->mock( >+ 'CanBookBeIssued', >+ sub { >+ return ( \%issuingimpossible, \%needsconfirmation, \%alerts, \%messages ); >+ } >+ ); >+ >+ $t->get_ok( >+"//$unauth_userid:$unauth_password@/api/v1/checkouts/availability?item_id=$item1_id&patron_id=$patron_id" >+ )->status_is(403)->json_is( >+ { >+ error => "Authorization failure. Missing required permission(s).", >+ required_permissions => >+ { circulate => "circulate_remaining_permissions" } >+ } >+ ); >+ >+ # Available >+ $t->get_ok( >+"//$userid:$password@/api/v1/checkouts/availability?item_id=$item1_id&patron_id=$patron_id" >+ )->status_is(200)->json_is( '/blockers' => {} ) >+ ->json_is( '/confirms' => {} )->json_is( '/warnings' => {} ) >+ ->json_is( '/confirmation_token' => undef ); >+ >+ # Blocked >+ %issuingimpossible = ( GNA => 1 ); >+ $t->get_ok( >+"//$userid:$password@/api/v1/checkouts/availability?item_id=$item1_id&patron_id=$patron_id" >+ )->status_is(200)->json_is( '/blockers' => { GNA => 1 } ) >+ ->json_is( '/confirms' => {} )->json_is( '/warnings' => {} ) >+ ->json_is( '/confirmation_token' => undef ); >+ %issuingimpossible = (); >+ >+ # Warnings/Info >+ %alerts = ( alert1 => "this is an alert" ); >+ %messages = ( message1 => "this is a message" ); >+ $t->get_ok( >+"//$userid:$password@/api/v1/checkouts/availability?item_id=$item1_id&patron_id=$patron_id" >+ )->status_is(200)->json_is( '/blockers' => {} ) >+ ->json_is( '/confirms' => {} ) >+ ->json_is( '/warnings' => >+ { alert1 => "this is an alert", message1 => "this is a message" } ) >+ ->json_is( '/confirmation_token' => undef ); >+ %alerts = (); >+ %messages = (); >+ >+ # Needs confirm >+ %needsconfirmation = ( confirm1 => 1, confirm2 => 'please' ); >+ $t->get_ok( >+"//$userid:$password@/api/v1/checkouts/availability?item_id=$item1_id&patron_id=$patron_id" >+ )->status_is(200)->json_is( '/blockers' => {} ) >+ ->json_is( '/confirms' => { confirm1 => 1, confirm2 => 'please' } ) >+ ->json_is( '/warnings' => {} ) >+ ->json_is( '/confirmation_token' => 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJjb25maXJtMSI6MSwiY29uZmlybTIiOjF9.4QBpITwnIGOAfohyKjaFDoeBWnGmQTdyJrPn9pavArw' ); >+ >+ $schema->storage->txn_rollback; >+}; >+ >+subtest 'add checkout' => sub { >+ >+ plan tests => 6; >+ >+ $schema->storage->txn_begin; >+ my $librarian = $builder->build_object( >+ { >+ class => 'Koha::Patrons', >+ value => { flags => 2 } >+ } >+ ); >+ my $password = 'thePassword123'; >+ $librarian->set_password( { password => $password, skip_validation => 1 } ); >+ my $userid = $librarian->userid; >+ >+ my $patron = $builder->build_object( >+ { >+ class => 'Koha::Patrons', >+ value => { flags => 0 } >+ } >+ ); >+ my $unauth_password = 'thePassword000'; >+ $patron->set_password( >+ { password => $unauth_password, skip_validattion => 1 } ); >+ my $unauth_userid = $patron->userid; >+ my $patron_id = $patron->borrowernumber; >+ >+ my $branchcode = $builder->build( { source => 'Branch' } )->{branchcode}; >+ >+ my $item1 = $builder->build_sample_item; >+ my $item1_id = $item1->id; >+ >+ my %issuingimpossible = (); >+ my %needsconfirmation = (); >+ my %alerts = (); >+ my %messages = (); >+ my $mocked_circ = Test::MockModule->new('C4::Circulation'); >+ $mocked_circ->mock( >+ 'CanBookBeIssued', >+ sub { >+ return ( \%issuingimpossible, \%needsconfirmation, \%alerts, \%messages ); >+ } >+ ); >+ >+ $t->post_ok( >+ "//$unauth_userid:$unauth_password@/api/v1/checkouts" => json => >+ { item_id => $item1_id, patron_id => $patron_id } )->status_is(403) >+ ->json_is( >+ { >+ error => "Authorization failure. Missing required permission(s).", >+ required_permissions => >+ { circulate => "circulate_remaining_permissions" } >+ } >+ ); >+ >+ $t->post_ok( "//$userid:$password@/api/v1/checkouts" => json => >+ { item_id => $item1_id, patron_id => $patron_id } )->status_is(201); >+ >+ # Needs confirm >+ %needsconfirmation = ( confirm1 => 1, confirm2 => 'please' ); >+ $t->post_ok( >+ "//$userid:$password@/api/v1/checkouts" => json => { >+ item_id => $item1_id, >+ patron_id => $patron_id, >+ } >+ )->status_is(412); >+ >+ my $token = "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJjb25maXJtMSI6MSwiY29uZmlybTIiOjF9.4QBpITwnIGOAfohyKjaFDoeBWnGmQTdyJrPn9pavArw"; >+ $t->post_ok( >+ "//$userid:$password@/api/v1/checkouts?confirmation=$token" => json => { >+ item_id => $item1_id, >+ patron_id => $patron_id >+ } >+ )->status_is(201)->or(sub { diag $t->tx->res->body }); >+ %needsconfirmation = (); >+ >+ $schema->storage->txn_rollback; >+}; >-- >2.40.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30979
:
139131
|
139132
|
139133
|
139134
|
141274
|
141275
|
141276
|
141277
|
141278
|
141279
|
141300
|
145264
|
145265
|
145266
|
145267
|
145268
|
145277
|
145280
|
145281
|
145282
|
145283
|
145284
|
145285
|
145620
|
145621
|
145622
|
145623
|
145624
|
145625
|
145626
|
145627
|
145628
|
145629
|
145630
|
150867
|
150868
|
150869
|
150870
|
150871
|
150872
|
150873
|
150874
|
150875
|
150876
|
150877
|
150878
|
150879
|
150880
|
150881
|
150882
|
150883
|
150884
|
150885
|
150886
|
150887
|
150888
|
150889
|
150967
|
150968
|
150969
|
150970
|
150971
|
150972
|
150973
|
150974
|
151254
|
151255
|
151256
|
151257
|
151258
|
151259
|
151260
|
151261
|
151358
|
151359
|
151360
|
151361
|
151362
|
151363
|
151364
|
151365
|
151368
|
151369
|
151370
|
151371
|
151372
|
151373
|
151374
|
151375
|
151376
|
152789
|
152790
|
152791
|
152792
|
152793
|
152794
|
152795
|
152796
|
152797
|
153459
|
153460
|
153461
|
153462
|
153463
|
153464
|
153465
|
153466
|
153467
|
153500
|
153501
|
153502
|
153503