Bugzilla – Attachment 150907 Details for
Bug 33512
Labels/buttons are confusing on serials-edit page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33512: (QA follow-up) Remove 'Click to' from buttons
Bug-33512-QA-follow-up-Remove-Click-to-from-button.patch (text/plain), 2.68 KB, created by
Katrin Fischer
on 2023-05-09 21:15:50 UTC
(
hide
)
Description:
Bug 33512: (QA follow-up) Remove 'Click to' from buttons
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-05-09 21:15:50 UTC
Size:
2.68 KB
patch
obsolete
>From 495e649ba027365d39a319bba875af996107ee5b Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sat, 15 Apr 2023 23:14:10 +0000 >Subject: [PATCH] Bug 33512: (QA follow-up) Remove 'Click to' from buttons > >This is following recommendations from accessibility >guidelines. It being a link or button already indicates >that you need to click it. We don't need to spell it out. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../intranet-tmpl/prog/en/modules/serials/serials-edit.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >index f887bb2bc4..d9cb9b1d55 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >@@ -230,7 +230,7 @@ $(document).ready(function() { > <tr> > <td colspan="6"> > <a id="label[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]" class="btn btn-default btn-sm" onclick="unHideItems('items[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]','label[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]', '[% serialslis.serialid | html %]');setStatus([% serialslis.serialid | html %]);"> >- Click to edit item</a> >+ Edit item</a> > <fieldset class="rows" style="display:none;" id="items[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]"> > <legend><a style="cursor: pointer;" onclick="HideItems('items[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]','label[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]')"> > Item</a> >@@ -383,7 +383,7 @@ $(document).ready(function() { > <tr> > <td colspan="6"> > <a id="label[% newserialloo.subscriptionid | html %][% newserialloo.serialid | html %]" class="btn btn-default btn-sm" onclick="unHideItems('items[% newserialloo.subscriptionid | html %][% newserialloo.serialid | html %]','label[% newserialloo.subscriptionid | html %][% newserialloo.serialid | html %]', '[% newserialloo.serialid | html %]')"> >- Click to add item</a> >+ Add item</a> > <fieldset class="rows" style="display:none;" id="items[% newserialloo.subscriptionid | html %][% newserialloo.serialid | html %]"> > <legend><a style="cursor: pointer;" onclick="HideItems('items[% newserialloo.subscriptionid | html %][% newserialloo.serialid | html %]','label[% newserialloo.subscriptionid | html %][% newserialloo.serialid | html %]')"> > Item</a> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33512
:
149580
|
149605
|
149719
|
149720
|
150179
|
150906
| 150907 |
150908