Bugzilla – Attachment 150908 Details for
Bug 33512
Labels/buttons are confusing on serials-edit page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33512: (follow-up) Check item count before adding add/edit button
Bug-33512-follow-up-Check-item-count-before-adding.patch (text/plain), 2.33 KB, created by
Katrin Fischer
on 2023-05-09 21:15:53 UTC
(
hide
)
Description:
Bug 33512: (follow-up) Check item count before adding add/edit button
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-05-09 21:15:53 UTC
Size:
2.33 KB
patch
obsolete
>From dd85117f04ef2e91fcb56c1eead7cb930c157d3b Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Mon, 24 Apr 2023 23:53:50 +0000 >Subject: [PATCH] Bug 33512: (follow-up) Check item count before adding > add/edit button > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../prog/en/modules/serials/serials-edit.tt | 11 +++++++++++ > 1 file changed, 11 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >index d9cb9b1d55..1a4d2e96e6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >@@ -229,8 +229,19 @@ $(document).ready(function() { > [% IF ( serialslis.serialsadditems ) %] > <tr> > <td colspan="6"> >+ [% SET item_count = 0 %] >+ [% FOREACH item IN serialslis.items %] >+ [% IF ( item.itemnumber ) %] >+ [% item_count = item_count + 1 %] >+ [% END %] >+ [% END %] >+ [% IF item_count > 0 %] > <a id="label[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]" class="btn btn-default btn-sm" onclick="unHideItems('items[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]','label[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]', '[% serialslis.serialid | html %]');setStatus([% serialslis.serialid | html %]);"> > Edit item</a> >+ [% ELSE %] >+ <a id="label[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]" class="btn btn-default btn-sm" onclick="unHideItems('items[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]','label[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]', '[% serialslis.serialid | html %]');setStatus([% serialslis.serialid | html %]);"> >+ Add item</a> >+ [% END %] > <fieldset class="rows" style="display:none;" id="items[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]"> > <legend><a style="cursor: pointer;" onclick="HideItems('items[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]','label[% serialslis.subscriptionid | html %][% serialslis.serialid | html %]')"> > Item</a> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33512
:
149580
|
149605
|
149719
|
149720
|
150179
|
150906
|
150907
| 150908