Attachment 150909 Details for Bug 33390 – Bug 33390: Add links to various system preference descriptions

[patch] Bug 33390: Add links to various system preference descriptions

Bug-33390-Add-links-to-various-system-preference-d.patch (text/plain), 9.92 KB, created by Katrin Fischer on 2023-05-09 21:40:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-05-09 21:40:05 UTC

Size: 9.92 KB

patch

obsolete

>From 3164b690352405ecb11f33370641cba61b2ed98d Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Mon, 3 Apr 2023 21:09:51 +0000
>Subject: [PATCH] Bug 33390: Add links to various system preference
> descriptions
>
>To test:
>1. Apply patch and look at the descriptions of the following system preferences. Make sure each link works and makes sense:
>
>DefaultLongOverdueChargeValue
>DefaultLongOverdueLostValue and DefaultLongOverdueDays
>DefaultLongOverdueSkipLostStatuses
>UpdateItemWhenLostFromHoldList
>
>NewItemsDefaultLocation
>UpdateItemLocationOnCheckin
>
>SkipHoldTrapOnNotForLoanValue
>UpdateNotForLoanStatusOnCheckin
>Reference_NFL_Statuses
>
>ItemsDeniedRenewal
>
>Signed-off-by: Catrina <catrina@bywatersolutions.com>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../admin/preferences/cataloguing.pref | 2 +-
> .../admin/preferences/circulation.pref | 26 ++++++++++---------
> .../en/modules/admin/preferences/opac.pref | 2 +-
> 3 files changed, 16 insertions(+), 14 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
>index 509153df23..ff8c9e6979 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
>@@ -119,7 +119,7 @@ Cataloging:
> - When items are created, give them the temporary location of
> - pref: NewItemsDefaultLocation
> class: short
>- - (should be a location code, or blank to disable).
>+ - (should be a <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=LOC">location code</a>, or blank to disable).
> -
> - pref: z3950NormalizeAuthor
> choices:
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>index cafd44be51..f5916435b6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>@@ -437,7 +437,7 @@ Circulation:
> 0: "don't ask"
> - "for confirmation."
> -
>- - By default, set the LOST value of an item to
>+ - By default, set the <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=LOST">LOST</a> value of an item to
> - pref: DefaultLongOverdueLostValue
> class: integer
> - when the item has been overdue for more than
>@@ -445,21 +445,21 @@ Circulation:
> class: integer
> - days.
> - WARNING â These preferences will activate the automatic item loss process. Leave these fields empty if you don't want to activate this feature.
>- - " Example: [1] [30] Sets an item to the LOST value 1 when it has been overdue for more than 30 days."
>+ - " Example: [1] [30] Sets an item to the <a href='/cgi-bin/koha/admin/authorised_values.pl?searchfield=LOST'>LOST</a> value 1 when it has been overdue for more than 30 days."
> - (Used when the longoverdue.pl script is called without the --lost parameter)
> - " NOTE: This system preference requires the <code>misc/cronjobs/longoverdue.pl</code> cronjob. Ask your system administrator to schedule it."
> -
>- - "Charge a lost item to the patron's account when the LOST value of the item changes to:"
>+ - "Charge a lost item to the patron's account when the <a href='/cgi-bin/koha/admin/authorised_values.pl?searchfield=LOST'>LOST</a> value of the item changes to:"
> - pref: DefaultLongOverdueChargeValue
> class: integer
> - Leave this field empty if you don't want to charge the patron for lost items.
> - (Used when the longoverdue.pl script is called without the --charge parameter)
> - " NOTE: This system preference requires the <code>misc/cronjobs/longoverdue.pl</code> cronjob. Ask your system administrator to schedule it."
> -
>- - When using the automatic item loss process, skip items with lost values matching any of
>+ - When using the automatic item loss process, skip items with <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=LOST">LOST</a> values matching any of
> - pref: DefaultLongOverdueSkipLostStatuses
> - "."
>- - Leave this field empty if you don't want to skip any lost statuses.
>+ - Leave this field empty if you don't want to skip any <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=LOST">LOST</a> statuses.
> - Set to a list of comma separated values, e.g. 5,6,7.
> -
> - "When issuing an item that has been marked as lost, "
>@@ -558,8 +558,8 @@ Circulation:
> - " Can name any field in the items table followed by a colon then a space then"
> - "a bracketed list of values separated by commas."
> - "For example:"
>- - " ccode: [NEWFIC,NULL,DVD]"
>- - " itype: [NEWBK,\"\"]"
>+ - " ccode: [NEWFIC,NULL,DVD] <a href='/cgi-bin/koha/admin/authorised_values.pl?searchfield=CCODE'>Collection codes</a>"
>+ - " itype: [NEWBK,\"\"] <a href='/cgi-bin/koha/admin/itemtypes.pl'>Item types</a>"
> - " NOTE: The word 'NULL' can be used to block renewal on undefined fields, while an empty string \"\" will block on an empty (but defined) field."
> -
> - pref: UpdateNotForLoanStatusOnCheckout
>@@ -577,11 +577,11 @@ Circulation:
> 0: "Don't trap"
> - items that are not for loan but holdable ( notforloan < 0 ) to fill holds.
> -
>- - Never trap items with 'not for loan' values of
>+ - Never trap items with <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=NOT_LOAN">'not for loan'</a> values of
> - pref: SkipHoldTrapOnNotForLoanValue
> class: integer
> - to fill holds.
>- - "(list of not for loan values separated with a pipe '|')"
>+ - "(list of <a href='/cgi-bin/koha/admin/authorised_values.pl?searchfield=NOT_LOAN'>not for loan</a> values separated with a pipe '|')"
> -
> - pref: HoldsAutoFill
> choices:
>@@ -632,6 +632,7 @@ Circulation:
> syntax: text/x-yaml
> class: code
> - "This is a list of value pairs. The first value is followed immediately by colon space then the second value. "
>+ - <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=LOC">Location codes</a> 
> - "Examples: "
> - "PROC: FIC - causes an item in the Processing Center location to be updated into the Fiction location on check in. "
> - "FIC: GEN - causes an item in the Fiction location to be updated into the General stacks location on check in. "
>@@ -651,7 +652,8 @@ Circulation:
> - This is a list of value pairs. When an item is checked in, if the not for loan value on the left matches the items not for loan value
> - "it will be updated to the right-hand value. For example, '-1: 0' will cause an item that was set to 'Ordered' to now be available for loan."
> - "Can be used for showing only the not for loan description. E.g. '-1: ONLYMESSAGE'."
>- - Each pair of values should be on a separate line.
>+ - "Each pair of values should be on a separate line. "
>+ - <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=NOT_LOAN">Not for loan values</a>
> -
> - pref: HidePersonalPatronDetailOnCirculation
> choices:
>@@ -956,8 +958,8 @@ Circulation:
> allow_and_notify: "Allow to mark items as lost and notify the patron"
> - from the 'Holds to pull' page. Values to be applied must be defined in <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=UpdateItemWhenLostFromHoldList">UpdateItemWhenLostFromHoldList</a>.
> -
>- - A list of values to update an item's values with when it is marked as lost from the 'Holds to pull' page.
>- - 'Example: "itemlost: 1" to set items.itemlost to 1 when the item is marked as lost. (Requires <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=CanMarkHoldsToPullAsLost">CanMarkHoldsToPullAsLost</a>)'
>+ - A list of values to update an item's values with when it is marked as <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=LOST">LOST</a> from the 'Holds to pull' page.
>+ - 'Example: "itemlost: 1" to set items.itemlost to 1 when the item is marked as <a href="/cgi-bin/koha/admin/authorised_values.pl?searchfield=LOST">LOST</a>. (Requires <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=CanMarkHoldsToPullAsLost">CanMarkHoldsToPullAsLost</a>)'
> - pref: UpdateItemWhenLostFromHoldList
> type: textarea
> syntax: text/x-yaml
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>index dbb3095010..96b28c547c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>@@ -317,7 +317,7 @@ OPAC:
> footer: "only footer"
> - "."
> -
>- - "List the following not for loan statuses as available for reference in OPAC search results:"
>+ - "List the following <a href='/cgi-bin/koha/admin/authorised_values.pl?searchfield=NOT_LOAN'>not for loan</a> statuses as available for reference in OPAC search results:"
> - pref: Reference_NFL_Statuses
> - "(Use | as delimiter.)"
> -
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33390: 149109 | 149110 | 150178 | 150909 | 150910 | 150911 | 158191 | 158192 | 158193 | 158200 | 158201 | 158202