Bugzilla – Attachment 150981 Details for
Bug 33277
Correctly handle linking subfields with no defined thesaurus
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33277: (follow-up) Fix notdefined search for Zebra and ES
Bug-33277-follow-up-Fix-notdefined-search-for-Zebr.patch (text/plain), 1.73 KB, created by
Marcel de Rooy
on 2023-05-10 12:10:08 UTC
(
hide
)
Description:
Bug 33277: (follow-up) Fix notdefined search for Zebra and ES
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-05-10 12:10:08 UTC
Size:
1.73 KB
patch
obsolete
>From dd3d0ad8a10cbcfdaed85ab782c823b70aaefc27 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 22 Mar 2023 00:33:23 +0000 >Subject: [PATCH] Bug 33277: (follow-up) Fix notdefined search for Zebra and ES >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Heading.pm | 2 +- > t/db_dependent/Heading.t | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Heading.pm b/C4/Heading.pm >index 5c393b4d53..b408622038 100644 >--- a/C4/Heading.pm >+++ b/C4/Heading.pm >@@ -241,7 +241,7 @@ sub _search { > # This is legal, so we do a fallback search > if( !$total && $thesaurus && !( grep /$thesaurus/,('lcsh','lcac','mesh','nal','notspecified','cash','rvm','sears','aat') ) ){ > pop @value; >- push @value, 'z'; >+ push @value, 'notdefined'; > $search_query = $builder->build_authorities_query_compat( > \@marclist, \@and_or, \@excluding, \@operator, > \@value, $self->{'auth_type'}, >diff --git a/t/db_dependent/Heading.t b/t/db_dependent/Heading.t >index d65132dbc9..7858054fda 100755 >--- a/t/db_dependent/Heading.t >+++ b/t/db_dependent/Heading.t >@@ -166,6 +166,6 @@ subtest "_search tests" => sub { > { term => { 'match-heading.ci_raw' => 'Uncles generalsubdiv Fiction' } }, > { term => { 'subject-heading-thesaurus.ci_raw' => 'z' } }, > ]; >- is_deeply( $terms, $expected_terms, "When thesaurus in subfield 2, and nothing is found, we should search again for 008_11 = z"); >+ is_deeply( $terms, $expected_terms, "When thesaurus in subfield 2, and nothing is found, we should search again for notdefined (008_11 = z) "); > > }; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33277
:
148417
|
148418
|
148419
|
148492
|
148493
|
148494
|
148495
|
148500
|
148527
|
148528
|
148529
|
148530
|
148531
|
148734
|
148735
|
148957
|
149837
|
149838
|
149839
|
149840
|
149841
|
149842
|
150890
|
150891
|
150977
|
150978
|
150979
|
150980
| 150981 |
150982
|
150983