Attachment 151062 Details for Bug 29822 – Bug 29822: Update unit tests

[patch] Bug 29822: Update unit tests

Bug-29822-Update-unit-tests.patch (text/plain), 3.54 KB, created by Martin Renvoize (ashimema) on 2023-05-11 08:42:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-05-11 08:42:57 UTC

Size: 3.54 KB

patch

obsolete

>From 0f710272123f49faeac872337f56ee94b0b126ee Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 10 Feb 2023 15:50:44 +0000
>Subject: [PATCH] Bug 29822: Update unit tests
>
>---
> t/db_dependent/selenium/patrons_search.t | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/t/db_dependent/selenium/patrons_search.t b/t/db_dependent/selenium/patrons_search.t
>index 3af2e6bf12..e01eb56821 100755
>--- a/t/db_dependent/selenium/patrons_search.t
>+++ b/t/db_dependent/selenium/patrons_search.t
>@@ -161,19 +161,19 @@ subtest 'Search patrons' => sub {
>     $driver->get( $base_url . "/members/members-home.pl" );
>     my @adv_options = $driver->find_elements('//select[@id="searchfieldstype"]/option');
>     is( scalar @adv_options, $nb_standard_fields + 1, 'All standard fields are searchable if DefaultPatronSearchFields not set. middle_name is there.');
>-    is( $adv_options[0]->get_value(), 'firstname,middle_name,surname,othernames,cardnumber,userid', 'Standard search uses hard coded list when DefaultPatronSearchFields not set');
>+    is( $adv_options[0]->get_value(), 'firstname|middle_name|surname|othernames|cardnumber|userid', 'Standard search uses hard coded list when DefaultPatronSearchFields not set');
>     my @filter_options = $driver->find_elements('//select[@id="searchfieldstype_filter"]/option');
>     is( scalar @filter_options, $nb_standard_fields + 1, 'All standard fields + middle_name are searchable by filter if DefaultPatronSearchFields not set');
>-    is( $filter_options[0]->get_value(), 'firstname,middle_name,surname,othernames,cardnumber,userid', 'Standard filter uses hard coded list when DefaultPatronSearchFields not set');
>-    C4::Context->set_preference('DefaultPatronSearchFields',"firstname,initials");
>+    is( $filter_options[0]->get_value(), 'firstname|middle_name|surname|othernames|cardnumber|userid', 'Standard filter uses hard coded list when DefaultPatronSearchFields not set');
>+    C4::Context->set_preference('DefaultPatronSearchFields',"firstname|initials");
>     $driver->get( $base_url . "/members/members-home.pl" );
>     @adv_options = $driver->find_elements('//select[@id="searchfieldstype"]/option');
>     is( scalar @adv_options, $nb_standard_fields, 'New option added when DefaultPatronSearchFields is populated with a field. Note that middle_name disappears, we do not want it if not part of DefaultPatronSearchFields');
>-    is( $adv_options[0]->get_value(), 'firstname,initials', 'Standard search uses DefaultPatronSearchFields when populated');
>+    is( $adv_options[0]->get_value(), 'firstname|initials', 'Standard search uses DefaultPatronSearchFields when populated');
>     @filter_options = $driver->find_elements('//select[@id="searchfieldstype_filter"]/option');
>     is( scalar @filter_options, $nb_standard_fields, 'New filter option added when DefaultPatronSearchFields is populated with a field');
>-    is( $filter_options[0]->get_value(), 'firstname,initials', 'Standard filter uses DefaultPatronSearchFields when populated');
>-    C4::Context->set_preference('DefaultPatronSearchFields',"firstname,initials,horses");
>+    is( $filter_options[0]->get_value(), 'firstname|initials', 'Standard filter uses DefaultPatronSearchFields when populated');
>+    C4::Context->set_preference('DefaultPatronSearchFields',"firstname|initials|horses");
>     $driver->get( $base_url . "/members/members-home.pl" );
>     @adv_options = $driver->find_elements('//select[@id="searchfieldstype"]/option');
>     @filter_options = $driver->find_elements('//select[@id="searchfieldstype_filter"]/option');
>-- 
>2.40.1

Actions: View | Diff | Splinter Review

Attachments on bug 29822: 144814 | 144831 | 146430 | 146445 | 146488 | 146489 | 146490 | 146491 | 146492 | 147433 | 147434 | 147435 | 147436 | 147437 | 149890 | 149891 | 149892 | 149893 | 149894 | 151058 | 151059 | 151060 | 151061 | 151062 | 151064 | 151233 | 151234 | 151235 | 151236 | 151237 | 151238 | 153373 | 153374 | 153375 | 153376 | 153377 | 153378 | 153379 | 153380 | 153381 | 153382 | 153383 | 153384 | 153442 | 153443 | 153444 | 153445 | 153446 | 153447 | 154361 | 154362 | 154363 | 154364 | 154365 | 154366