Bugzilla – Attachment 151072 Details for
Bug 33624
Using Browser "Back" button in Batch Record Modification causes biblio options to be displayed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33624: Hide the "list" tab if authority is selected
Bug-33624-Hide-the-list-tab-if-authority-is-select.patch (text/plain), 2.73 KB, created by
Jonathan Druart
on 2023-05-11 12:39:41 UTC
(
hide
)
Description:
Bug 33624: Hide the "list" tab if authority is selected
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2023-05-11 12:39:41 UTC
Size:
2.73 KB
patch
obsolete
>From 6b8fe2008163d21bef5678af47d5aa6d01925c44 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 11 May 2023 14:35:23 +0200 >Subject: [PATCH] Bug 33624: Hide the "list" tab if authority is selected > >The "Select a list of records" should only be available for biblio >records. But if the page is accessed using the back button of the >browser it will be displayed for authorities as well. > >Test plan: >- Make sure you have at least one template for MARC Modification >- Also make sure you have at least one list of biblio records >- navigate to Cataloging -> Batch record modification >- Check the "Authorities" radio button >- Select your template and continue >- No records were modified -> use your browser's Back button to go back one page >- The "Authorities" radio button should still be selected >=> Without this patch you see the tab "Select a list of records" >=> With this patch applied it's hidden when the page is loaded >--- > .../tools/batch_record_modification.tt | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt >index a0b63de3316..de54b305686 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt >@@ -285,16 +285,21 @@ > [% INCLUDE 'datatables.inc' %] > [% Asset.js("lib/jquery/plugins/humanmsg.js") | $raw %] > <script> >+ function update_tab_display(){ >+ let selected_type = $('input[name="recordtype"]:checked').val(); >+ if (selected_type == 'authority') { >+ $("a[href='#shelves_tab_panel']").parent().hide(); >+ $("a[href='#uploadfile_tab_panel']").tab("show"); >+ } else if (selected_type == 'biblio') { >+ $("a[href='#shelves_tab_panel']").parent().show(); >+ $("a[href='#uploadfile_tab_panel']").tab("show"); >+ } >+ } > $(document).ready(function() { > >+ update_tab_display(); > $("input[type='radio']").click(function() { >- if ($(this).attr('id') == 'authority_type') { >- $("a[href='#shelves_tab_panel']").parent().hide(); >- $("a[href='#uploadfile_tab_panel']").tab("show"); >- } else if ($(this).attr('id') == 'biblio_type') { >- $("a[href='#shelves_tab_panel']").parent().show(); >- $("a[href='#uploadfile_tab_panel']").tab("show"); >- } >+ update_tab_display(); > }); > > $("#selectall").click(function(e){ >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33624
:
151072
|
151327
|
151335